Reserve - #437
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the reserve_contract is the only contract with correct TTL handling, access control, and bounds checking — and it's unused
Location: contracts/reserve_contract/src/lib.rs (entire contract) vs the cross-contract TTL/disconnection issues above
Root cause / scenario:
reserve_contract calls storage::extend_instance_ttl(&env) at the top of every single function, correctly gates set_base_reserve behind a stored admin's require_auth(), validates amount bounds (0 < amount <= MAX_RESERVE_STROOPS), and has 20 passing tests — the strongest-built contract in the workspace by a clear margin.
Impact:
None of this care currently has any effect on the deployed system's behavior, since (per the cross-contract 'orphaned reserve_contract' issue above) nothing else in the codebase ever calls it.
closes #247
closes #245