docs(audit): add runbooks for sweep-event reconstruction (#287) and trustline pre-validation (#291) - #435
Merged
phertyameen merged 1 commit intoJul 26, 2026
Conversation
…validation Closes the two operational-runbook gaps assigned to @judithJn: - bridgelet-org#287 bridgelet-audit/runbooks/audit-sweep-event-logs.md Documents how to reconstruct a sweep's full history from on-chain event logs alone across both EphemeralAccount and SweepController, the cross-contract correlation methodology, and the explicit gaps in event coverage today (payment-event pairing semantics, missing sweep_id correlation, claim() vs execute_sweep event signatures, per-transfer success/failure). - bridgelet-org#291 bridgelet-audit/runbooks/token-trustline-validation-before-sweep.md Documents the caller-side pre-flight checks required because SweepController::transfers::execute_transfers has no in-contract trustline gate today, including the per-asset decision matrix, row-level guidance on interpreting a failed sweep as a trustline vs other transfer failure, and the explicit limitations regarding the claim() path. Both files are documentation-only additions to the bridgelet-audit knowledge base; no contracts/, docs/, scripts/, or tools/ paths are touched, matching the stated scope of issues bridgelet-org#287 and bridgelet-org#291.
|
@judithJn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
phertyameen
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit runbooks for sweep-event reconstruction and trustline pre-validation
Closes the two operational-runbook gaps currently assigned to @judithJn in the
bridgelet-audit/knowledge base:Both files are documentation-only additions scoped to the `bridgelet-audit/runbooks/` directory. No changes to `contracts/`, `docs/`, `scripts/`, or `tools/`, matching the stated scope of both issues.
What this PR adds
`audit-sweep-event-logs.md` (closes #287)
Operational runbook describing how to reconstruct a single sweep’s full on-chain history from emitted event logs alone. Covers:
`token-trustline-validation-before-sweep.md` (closes #291)
Operational runbook for caller-side pre-flight validation that every record-payment asset can be received by the proposed sweep destination, because `SweepController::transfers::execute_transfers(...)` has no in-contract trustline gate today. Covers:
Why a single PR
The two issues are sibling gaps in the same `bridgelet-audit/runbooks/` knowledge-base initiative, both assigned to the same author, both explicitly scoped to be documentation-only additions to that folder, and both part of the bridgelet-audit knowledge-base initiative (36/100 and 40/100 respectively). Keeping them in one PR makes sense and matches the standard practice of grouping related knowledge-base contributions.
CI
The repo README documents that `.github/workflows/test.yml` is fully commented out and `.github/workflows/deploy-testnet.yml` only runs validation for Rust crates. This PR touches no Rust source and no script — only two new markdown files in `bridgelet-audit/runbooks/` — so there is no build, fmt, clippy, or test gate that could regress. CI is a no-op for this change by design.
Verification
Files
```text
docs/audit-runbooks-judithjn-287-291 (commit 0f4dbfc)
2 files changed, 338 insertions(+)
```