docs: add account-factory salt-collision recovery runbook - #434
Merged
phertyameen merged 1 commit intoJul 26, 2026
Merged
Conversation
Add bridgelet-audit/runbooks/account-factory-salt-collision-recovery.md, an operational guide for diagnosing batch_initialize entries that return success: false, including computing the deterministic address for a salt/index to check for cross-batch collisions.
|
@Nimatstar Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
bridgelet-audit/runbooks/account-factory-salt-collision-recovery.md, anoperational runbook for diagnosing why an
AccountFactory::batch_initializecall returned
success: falsefor some or all requests.Contents
AccountInitResult.erroris currently alwaysNone, soroot-causing requires external diagnostic-event /
simulateTransaction/ loginspection rather than the on-chain return value.
indexin the last 4 bytes of a32-byte salt) and how to compute the expected deterministic contract address
for a given salt/index to check whether a cross-batch collision is the cause.
InvalidExpiry,AlreadyInitialized) and a diagnostic checklist.Documentation-only, in a new standalone
bridgelet-audit/folder — no changesto
contracts/,docs/,scripts/, ortools/. Per the issue, it documentsdiagnosis only and does not propose the underlying code fix.
Closes #281