feat(sweep_controller): emit SweepExecutedMulti with per-asset paymen…#400
Merged
phertyameen merged 1 commit intoJul 26, 2026
Conversation
…t breakdown execute_transfers already handled multi-asset transfers via a loop over all recorded payments. The documented SweepExecutedMulti event was never defined or wired up on either sweep path. Add the event type and emit it from both execute_sweep() (via sweep_account()) and claim(), alongside the existing SweepCompleted summary event. Adds test_claim_emits_sweep_executed_multi_with_all_assets covering the gas-free claim() path with 2 distinct assets. Closes bridgelet-org#149
|
@vaishnavidesai09 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
@Ibinola review this pr |
phertyameen
approved these changes
Jul 26, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-asset token transfer already worked — `execute_transfers` loops
over every recorded payment. The gap was the documented
`SweepExecutedMulti` event: it existed only in interface docs, never
defined or emitted on either sweep path.
(needless_borrow, get_first) in tests/integration.rs unrelated to this
change — not touched here, flagging separately rather than folding an
unrelated cleanup into this PR" \
Closes #149