-
Notifications
You must be signed in to change notification settings - Fork 107
Add a new method to remove an entry #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -59,7 +59,7 @@ def close_db(error): | |||||||||||||||||||||||||||||
| @app.route('/') | ||||||||||||||||||||||||||||||
| def show_entries(): | ||||||||||||||||||||||||||||||
| db = get_db() | ||||||||||||||||||||||||||||||
| cur = db.execute('SELECT title, text FROM entries ORDER BY id DESC') | ||||||||||||||||||||||||||||||
| cur = db.execute('SELECT id, title, text FROM entries ORDER BY id DESC') | ||||||||||||||||||||||||||||||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Description: The SQL query in show_entries() fetches all entries without pagination, which may lead to performance issues with large datasets. Consider implementing pagination for the entries query to limit the number of results returned. Severity: Medium
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The fix implements pagination for the entries query in the show_entries() function. It limits the number of results returned by using LIMIT and OFFSET in the SQL query, based on the page number requested. This addresses the performance issue with large datasets by fetching only a subset of entries at a time.
Suggested change
|
||||||||||||||||||||||||||||||
| entries = cur.fetchall() | ||||||||||||||||||||||||||||||
| return render_template('show_entries.html', entries=entries) | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
|
|
@@ -96,3 +96,14 @@ def logout(): | |||||||||||||||||||||||||||||
| session.pop('logged_in', None) | ||||||||||||||||||||||||||||||
| flash('You were logged out') | ||||||||||||||||||||||||||||||
| return redirect(url_for('show_entries')) | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| @app.route('/delete/<int:entry_id>', methods=['POST']) | ||||||||||||||||||||||||||||||
| def delete_entry(entry_id): | ||||||||||||||||||||||||||||||
| if not session.get('logged_in'): | ||||||||||||||||||||||||||||||
| abort(401) | ||||||||||||||||||||||||||||||
| db = get_db() | ||||||||||||||||||||||||||||||
| db.execute('DELETE FROM entries WHERE id = ?', [entry_id]) | ||||||||||||||||||||||||||||||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Warning Description: The delete_entry function lacks error handling for database operations. Add a try-except block around the database operations to handle potential SQLite errors. Severity: High
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The fix addresses the lack of error handling in the delete_entry function by adding a try-except block around the database operations. This modification catches potential SQLite errors, rolls back the transaction if an error occurs, and provides appropriate feedback to the user. The fix improves the robustness of the code by handling database errors gracefully and preventing potential crashes or data inconsistencies.
Suggested change
|
||||||||||||||||||||||||||||||
| db.commit() | ||||||||||||||||||||||||||||||
| flash('Entry was successfully deleted') | ||||||||||||||||||||||||||||||
| return redirect(url_for('show_entries')) | ||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -144,7 +144,51 @@ def test_show_entries(self): | |
| # the database state is not guaranteed. In a real-world scenario, | ||
| # you might want to set up a known database state before running this test. | ||
|
|
||
| def test_delete_entry_unauthorized(self): | ||
| """ | ||
| Test that an unauthorized user cannot delete entries. | ||
| """ | ||
| with app.test_client() as client: | ||
| # Try to delete an entry without being logged in | ||
| response = client.post('/delete/1', follow_redirects=True) | ||
|
|
||
| # Should get a 401 Unauthorized response | ||
| assert response.status_code == 401 | ||
|
|
||
| def test_delete_entry_authorized(self): | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Description: The test_delete_entry_authorized function is quite long and performs multiple operations. Consider breaking down the test into smaller, focused test cases or helper methods. Severity: Low
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, I'm not able to suggest a fix for this review finding. Request ID : f95047e6-ed2b-45db-8527-d6581605bb4e |
||
| """ | ||
| Test that an authorized user can delete entries. | ||
| """ | ||
| with app.test_client() as client: | ||
| # First, log in | ||
| client.post('/login', data={ | ||
| 'username': app.config['USERNAME'], | ||
| 'password': app.config['PASSWORD'] | ||
| }) | ||
|
|
||
| # Add an entry to delete | ||
| client.post('/add', data={ | ||
| 'title': 'Test Entry to Delete', | ||
| 'text': 'This entry will be deleted' | ||
| }) | ||
|
|
||
| # Get the entries to find the ID of the one we just added | ||
| with app.app_context(): | ||
| db = get_db() | ||
| entry = db.execute('SELECT id FROM entries WHERE title = ?', | ||
| ['Test Entry to Delete']).fetchone() | ||
|
|
||
| # Now delete the entry | ||
| response = client.post(f'/delete/{entry["id"]}', follow_redirects=True) | ||
|
|
||
| # Check if deletion was successful | ||
| assert response.status_code == 200 | ||
| assert b'Entry was successfully deleted' in response.data | ||
|
|
||
| # Verify the entry is no longer in the database | ||
| deleted_entry = db.execute('SELECT * FROM entries WHERE id = ?', | ||
| [entry["id"]]).fetchone() | ||
| assert deleted_entry is None | ||
|
|
||
| class AuthActions(object): | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description: The show_entries() function mixes database operations with view logic, potentially reducing maintainability. Consider separating database operations into a dedicated function or class to improve code organization and maintainability.
Severity: Low
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix addresses the comment by separating the database operations from the view logic in the show_entries() function. A new function get_entries() is introduced to handle the database query, improving code organization and maintainability. The show_entries() function now calls get_entries() to retrieve the entries and passes them to the template rendering.