Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore non-havePack64 logic for negative integers #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Restore non-havePack64 logic for negative integers #30

wants to merge 1 commit into from

Conversation

trwyant
Copy link
Contributor

@trwyant trwyant commented Jan 21, 2025

This was dropped in the refactor of 1.505. I guess Perls without 64-bit integers are rare these days; I only encountered it on a Raspberry Pi.

@trwyant
Restore non-havePack64 logic for negative integers
c27baff 
This was dropped in the refactor of 1.505. I guess Perls without 64-bit
integers are rare these days; I only encountered it on a Raspberry Pi.
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant temporarily deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Inactive
@trwyant trwyant deployed to automated_testing January 21, 2025 16:29 — with GitHub Actions Active
@coveralls
Copy link

coveralls commented Jan 21, 2025 •
edited
Loading

Coverage Status

coverage: 87.091% (-0.4%) from 87.455%
when pulling c27baff on trwyant:trw_restore_non_havePack64_negative_numbers
into d169b9c on briandfoy:master.

@coveralls
Copy link

Coverage Status

coverage: 87.091% (-0.4%) from 87.455%
when pulling c27baff on trwyant:trw_restore_non_havePack64_negative_numbers
into d169b9c on briandfoy:master.

3 similar comments
@coveralls
Copy link

Coverage Status

coverage: 87.091% (-0.4%) from 87.455%
when pulling c27baff on trwyant:trw_restore_non_havePack64_negative_numbers
into d169b9c on briandfoy:master.

@coveralls
Copy link

Coverage Status

coverage: 87.091% (-0.4%) from 87.455%
when pulling c27baff on trwyant:trw_restore_non_havePack64_negative_numbers
into d169b9c on briandfoy:master.

@coveralls
Copy link

Coverage Status

coverage: 87.091% (-0.4%) from 87.455%
when pulling c27baff on trwyant:trw_restore_non_havePack64_negative_numbers
into d169b9c on briandfoy:master.

@briandfoy
Copy link
Owner

Can you verify that the macOS plists tools can handle these numbers? As I recall, we had to drop some of this stuff because we were generating plist files that would cause problems. I noted in the Changes that these numbers had to be longs.

Along with this, could you add some tests to write and read the data to verify they round trip?

@briandfoy briandfoy added Type: feature request add a feature that does not exist Status: needs testing the fix needs to be tested Status: changes requested adjust the pull request as noted in comments labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: changes requested adjust the pull request as noted in comments Status: needs testing the fix needs to be tested Type: feature request add a feature that does not exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trwyant @coveralls @briandfoy