Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle timeouts more gracefully by allowing the application to shutdown #895

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Handle timeouts more gracefully by allowing the application to shutdown #895

wants to merge 9 commits into from

Commits on Mar 26, 2021

  1. Handle timeouts more gracefully by throwing exception near the hard end

    @Nyholm
    Nyholm committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    e78d2c6 View commit details
    Browse the repository at this point in the history

  2. Added documentation for Timeouts

    @Nyholm
    Nyholm committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    5a57044 View commit details
    Browse the repository at this point in the history

  3. Adding a note about debugging

    @Nyholm
    Nyholm committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    b89aa04 View commit details
    Browse the repository at this point in the history

  4. Make Timeout::init() private

    @Nyholm
    Nyholm committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    52f8d65 View commit details
    Browse the repository at this point in the history

  5. Make this feature opt-in

    @Nyholm
    Nyholm committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    37a5759 View commit details
    Browse the repository at this point in the history

  6. Make sure the shutdown process has at least 1 second.

    @Nyholm
    Nyholm committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    a2e46ca View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Always base the timeout duration on the configured Lambda timeout (#3) 

    * Always base the timeout duration on the configured Lambda timeout

* Make sure that we can never enable the Bref timeout in the FPM bootstrap process

* Remove unnecessary private method `timeoutAfter()`

* Allow using falsy values for `BREF_FEATURE_TIMEOUT`, e.g. `0` or `''`, to allow disabling the feature

* Cleanup global state

* Improve tests following @Nyholm's feedback
    @mnapoli
    mnapoli committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    0b6d7b2 View commit details
    Browse the repository at this point in the history

  2. Do 2 alarms

    @Nyholm
    Nyholm committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    9356e4a View commit details
    Browse the repository at this point in the history

  3. fixed tests

    @Nyholm
    Nyholm committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    2efd449 View commit details
    Browse the repository at this point in the history