fix: code cleanup (#48)

* chore: cleaning file names in client

* fix: cleaning up server code

* fix: removing tests from worker

client/app/_components/ErrorAlert.tsx → client/app/_components/error-alert.tsx

@@ -4,7 +4,7 @@ import { useSearchParams } from "next/navigation";
 
 import { Alert, AlertDescription, AlertTitle } from "@/components/ui/alert";
 
-export default function ErrorAlert() {
+export function ErrorAlert() {
   const searchParams = useSearchParams();
   const error = searchParams.get("error");
 

client/app/_components/UserLogin.tsx → client/app/_components/user-login.tsx

@@ -20,7 +20,7 @@ const loginFormSchema = z.object({
 
 interface UserLoginProps extends React.HTMLAttributes<HTMLDivElement> {}
 
-export default function UserLogin({ className, ...props }: UserLoginProps) {
+export function UserLogin({ className, ...props }: UserLoginProps) {
   const form = useForm<z.infer<typeof loginFormSchema>>({
     resolver: zodResolver(loginFormSchema),
     defaultValues: {

client/app/page.tsx

@@ -1,8 +1,8 @@
 import type { Metadata } from "next";
 import { Suspense } from "react";
 
-import ErrorAlert from "./_components/ErrorAlert";
-import UserLogin from "./_components/UserLogin";
+import { ErrorAlert } from "./_components/error-alert";
+import { UserLogin } from "./_components/user-login";
 
 export const metadata: Metadata = {
   // template is not supported in siblings

client/app/private/dashboard/page.tsx

@@ -1,6 +1,6 @@
 import type { Metadata } from "next";
 
-import { PageHeader } from "@/components/PageHeader";
+import { PageHeader } from "@/components/page-header";
 import { Card, CardContent, CardDescription, CardHeader, CardTitle } from "@/components/ui/card";
 import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs";
 

client/app/private/settings/layout.tsx

@@ -1,6 +1,6 @@
 import type { Metadata } from "next";
 
-import { PageHeader } from "@/components/PageHeader";
+import { PageHeader } from "@/components/page-header";
 
 import { SettingsNav } from "./_components/settings-nav";
 

server/.pylintrc

@@ -437,7 +437,8 @@ disable=raw-checker-failed,
         missing-module-docstring,
         missing-class-docstring,
         missing-function-docstring,
-        unrecognized-option
+        unrecognized-option,
+        too-few-public-methods
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option

server/app/errors.py

@@ -1,18 +0,0 @@
-class MissingEnvException(Exception):
-    pass
-
-
-class DatabaseNotConnectedException(Exception):
-    pass
-
-
-class UserAlreadyExistsException(Exception):
-    pass
-
-
-class WeakPasswordException(Exception):
-    pass
-
-
-class InvalidEmailException(Exception):
-    pass

server/app/main.py

@@ -3,7 +3,7 @@
 from starlette.middleware.sessions import SessionMiddleware
 
 from app.middlewares.auth_session import AuthSessionMiddleware
-from app.routes import auth, integration_routes, session_routes, ticks
+from app.routes import auth_routes, integration_routes, session_routes
 from app.services.env import SESSION_SECRET
 
 # @asynccontextmanager
@@ -30,9 +30,8 @@
 app.add_middleware(AuthSessionMiddleware)
 app.add_middleware(SessionMiddleware, secret_key=SESSION_SECRET)
 
-app.include_router(auth.router)
+app.include_router(auth_routes.router)
 app.include_router(session_routes.router)
-app.include_router(ticks.router)
 app.include_router(integration_routes.router)
 
 

server/app/routes/auth.py → server/app/routes/auth_routes.py

@@ -1,9 +1,6 @@
 from fastapi import APIRouter, HTTPException, Request
 from pydantic import BaseModel
 
-from app.errors import (
-    InvalidEmailException,
-)
 from app.helpers.auth import compare_passwords, hash_password
 from app.helpers.models import User, UserInDB
 from app.helpers.session import Session, SessionManager
@@ -57,7 +54,7 @@ async def signup(body: SignupBody):
 @router.post("/login", response_model=LoginResponse, response_model_by_alias=False)
 async def login(request: Request, body: LoginBody):
     if not is_valid_email(body.email):
-        raise InvalidEmailException("Email is invalid")
+        raise HTTPException(status_code=400, detail="Email is invalid")
     user = db.users.find_one({"email": body.email})
     if not user:
         raise HTTPException(status_code=401, detail="Invalid credentials")

server/app/services/db.py

@@ -2,10 +2,15 @@
 from pymongo.collection import Collection
 from pymongo.database import Database
 
-from app.errors import MissingEnvException
 from app.helpers.auth import hash_password
 from app.helpers.models import UserInDB
-from app.services.env import ADMIN_EMAIL, ADMIN_PASSWORD, MONGODB_DB_NAME, MONGODB_URI
+from app.services.env import (
+    ADMIN_EMAIL,
+    ADMIN_PASSWORD,
+    MONGODB_DB_NAME,
+    MONGODB_URI,
+    MissingEnvException,
+)
 
 
 class Db:

server/app/services/env.py

@@ -13,4 +13,9 @@
 REDIS_URI: str = getenv("REDIS_URI")
 ENC_KEY: str = getenv("ENC_KEY")
 
+
+class MissingEnvException(Exception):
+    pass
+
+
 print("[Initialized] Environment Variables")

tick-workers/README.md

@@ -43,5 +43,3 @@ To run `stonk.ninja tick-worker` locally, run the following command:
 pnpm run dev [worker-type]
 ```
 `worker-type` can either be a `producer` or a `recorder`.
-
-# test