Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve readability in zh #79

Closed
wants to merge 1 commit into from
Closed

improve readability in zh #79

wants to merge 1 commit into from

Conversation

aidewoode
Copy link
Contributor

For the readability, I add space between the Chinese and English letter. And I also change some translation to make it easier to understand. Now I just finished the first chapter, and the rest chapter I will do it later.

@braydie
Copy link
Owner

braydie commented Mar 29, 2016

hey @aidewoode thanks for the contribution! based on some of the feedback in another issue we've had around translations, before merging in I'd like to get a second set of eyes to review the changes you've made (as I can't verify them myself, unfortunately!)

@ahangchen wrote the original translation so they'd be the best person to review I believe

@ahangchen
Copy link
Collaborator

@aidewoode For fixes of Chinese version, please open a pull request into this repository https://github.com/ahangchen/HowToBeAProgrammer.

@aidewoode
Copy link
Contributor Author

@ahangchen Is there any difference between the two repository?, why I should pull another same request to a fork repository?

@ahangchen
Copy link
Collaborator

@aidewoode Because Braydie can't review it without understanding Chinese, and this repository is the original translation for Chinese, so I will help to review fixes for Chinese version and finally push them to this repository, as mentioned in this issue #45

@aidewoode
Copy link
Contributor Author

yeah, I get it, but I think maybe it's not a good idea. Because, first, we have to merge twice for the same purpose, it's seem less efficient. And second, imagine this, when we have others translation version, like Spanish, Japanese or some thing else in the later , and a contributor want to translate some to Chinese, and also want to translate some to Japanese, maybe he also want to change some original English content. If we have fork repository for each translation version, he have to fork at least three repository, and separate one commit to three for the each repository, I think this will made him so sad.

I think in this repository you can review Chinese too, When have some Chinese translation contribution, I think @braydie will mention you, and you can mention others Chinese contributor to review this commit together. I think just contribute to one repository will be simpler.

@ahangchen
Copy link
Collaborator

Contributing to one repository is simpler for the contributor, but not for the manager.
Solving problems in the corresponding branch is why git is charming.
Although we have to merge twice, it's clearer.
By the way, it's unnecessary to fork each translation version, actually, github will prevent you from doing this. You can open a PR to any branch by simply choosing the base fork in the PR page.

@aidewoode
Copy link
Contributor Author

@ahangchen all right, I will push another quest , and this PR will be closed

@aidewoode aidewoode closed this Mar 30, 2016
@braydie
Copy link
Owner

braydie commented Mar 30, 2016

I agree with both of you on this - it makes sense to have a single repository for ease of contribution but is difficult to manage, particularly as it is just me at the moment. Perhaps the solution to this would be making the person who makes the initial contribution of a translation an official contributor for this project, that way they can manage pull requests that come through for 'their' language

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants