Add Dev Menu #98
Draft
Add Dev Menu #98
+1,235
−1,012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschfh
force-pushed
the
mschfh-dev-mode
branch
from
2e40df1
to
8508502
Compare
antonok-edm
reviewed
Dec 4, 2024
| @@ -236,6 +237,16 @@ export const checkPage = async (args) => { | |||
|
|
|||
| await setTimeout(waitTimeMs) | |||
|
|
|||
| if (mode === 'mhtml') { | |||
There was a problem hiding this comment.
Instead of a new mode, can this work like the screenshot feature (i.e. the MHTML export is attached as an optional additional part of the request)? This would be much easier to use in a crawl context where we'd be interested in snapshotting the exact page where a cookie notice was detected.
| </div> | ||
| </form> | ||
| <div id="spinner">🍪</div> | ||
| <div id="reportlist"></div> | ||
| <footer> | ||
| <a href="https://github.com/brave/cookiemonster">Source code</a> | ||
| <span class="version">{{ version }}</span> |
There was a problem hiding this comment.
showing version is a great idea 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.