Repository navigation
review-agents.md: what bypass lets a bravebot session reach - #3
Merged
bbondy merged 1 commit intoNov 13, 2026
Merged
Conversation
The bravebot section said programs `run` starts could write only the work directory. bravebot's own specs say otherwise. Under --dangerously-skip-permissions with --trust-workspace and --sandbox workspace-write, the file tools and programs may read and write any path the account can, less bravebot's fixed refusals and our deny rules (PATHREQ-7, SANDBOX-28). Bypass also approves writes to protected paths such as .git (MODE-4). That leaves the target repository writable, so a misled session could plant a git hook there, and the next prepare-review.py would run it as the reviewer. The doc now says so, lists what bravebot still refuses, spells out claude's controls, and lists the bravebot changes that would give it parity.
bbondy
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only. This corrects the bravebot section of
docs/review-agents.md.What was wrong. The doc said programs started by
runcould write only the work directory. bravebot's own specs (0.21.0) say otherwise. Under--dangerously-skip-permissionswith--trust-workspaceand--sandbox workspace-write, the file tools and programs can read and write any path the account can (PATHREQ-7, SANDBOX-28). Only bravebot's fixed refusals and our deny rules still hold. Bypass also approves writes to protected paths such as.git(MODE-4).Why it matters. Nothing denies writes to
project.targetRepoPath. A session misled by a PR could plant a git hook there. The nextprepare-review.pywould then run it duringgit worktree add, as the reviewer and outside any confinement. The doc now names this, along with the fix: anEditdeny rule plus--sandbox-deny-writeon the target repo. That code change is not part of this PR.Also in this PR
--strict-mcp-config.dontAsk. Today any decline ends the run (CLI-1, CLI-36),--approve-input-linesincluded;python3can still start on Linux.Testing: the bravebot behaviour comes from reading its specs. It was not observed in a run.
pytest tests/passes (601 passed, 4 skipped).