fix: mobile ticker spacing collisions and sidebar scroll clipping - #118
Open
brandonpham13 wants to merge 1 commit into
Open
fix: mobile ticker spacing collisions and sidebar scroll clipping#118brandonpham13 wants to merge 1 commit into
brandonpham13 wants to merge 1 commit into
Conversation
Ticker: widen the gap around "vs" and rebalance the divider padding so team 1's score, "vs", and the week label no longer visually collide at narrow widths; add w-max/shrink-0 so the marquee track's width can't shrink-collapse. Sidebar: make the nav its own scroll region (flex-1 min-h-0 overflow-y-auto) instead of relying on the fixed drawer to fit everything, so a long Teams list no longer pushes the pinned Huddles/Account footer off-screen. Footer also clears the iOS home indicator via env(safe-area-inset-bottom). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on UI improvements for the sidebar and dashboard ticker components, primarily addressing layout, spacing, and mobile usability. The most important changes are grouped below by component.
Sidebar layout and mobile usability improvements:
<nav>is now a scrollable region (flex-1 min-h-0 overflow-y-auto), ensuring that long lists do not push the footer out of view and keeping the footer accessible on all screen sizes.env(safe-area-inset-bottom)) and no longer grows with the sidebar content, improving accessibility and usability on mobile devices.Dashboard ticker visual and spacing enhancements:
pl-5 pr-6), explicit gaps around the "vs" separator, and made several elements non-shrinking to maintain consistent layout at mobile widths. [1] [2] [3]w-maxto ensure smooth, seamless looping of ticker items.Ticker: widen the gap around "vs" and rebalance the divider padding so team 1's score, "vs", and the week label no longer visually collide at narrow widths; add w-max/shrink-0 so the marquee track's width can't shrink-collapse.
Sidebar: make the nav its own scroll region (flex-1 min-h-0 overflow-y-auto) instead of relying on the fixed drawer to fit everything, so a long Teams list no longer pushes the pinned Huddles/Account footer off-screen. Footer also clears the iOS home indicator via env(safe-area-inset-bottom).