Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Commit

Permalink
Update README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
@bweissbart
bweissbart authored Oct 25, 2019
1 parent 9aa8ddc commit a1b5273
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,14 @@

[![npm version](https://badge.fury.io/js/%40brandingbrand%2Freact-native-leanplum.svg)](https://badge.fury.io/js/%40brandingbrand%2Freact-native-leanplum)

> README is WiP
# Supported React Native Versions

This library was updated to support React Native autolinking in version 5.0; therefore it is not recommended to upgrade to version 5 unless you are running React Native 0.60 or above.

|React Native|React Native Leanplum|
|------------|---------------------|
| 0.60.0+|5.0.0|
| 0.40.0 - 0.59.x|4.0.0|

# Install

Expand Down

7 comments on commit a1b5273

@linamm
Copy link

@linamm linamm commented on a1b5273 Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @bweissbart, looks like the latest version you've released is version 4.0.0. Is that correct? I am a bit confused why there is a reference of of version 5.0.0 on npm?

@bweissbart
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linamm - we do have a 5.0.0 release but it's only compatible with RN 0.60.0 and above.

@linamm
Copy link

@linamm linamm commented on a1b5273 Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, Ok, thanks for confirming this.
From this release page, https://github.com/brandingbrand/react-native-leanplum/releases,
I can only see version 4. Can you advise me how to see the diff between 4.0.0 and 5.0.0?

@bweissbart
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon closer inspection, it appears that we had a misfire from semantic-release. 4.0 contains the auto-linking changes and SDK updates, and 5.0 should have not been created. I removed the v5 release, updated the README, and edited the v4 release: https://github.com/brandingbrand/react-native-leanplum/releases/tag/v4.0.0

Thanks for bringing this to our attention!

@linamm
Copy link

@linamm linamm commented on a1b5273 Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um... we are using react-native 0.59.10 and v5.0.0 has caused us a bit of an issue. then we reverted to v4.0.0 and it is working fine.
By editing the v4.0.0, will that mean our issue will come back now?

@linamm
Copy link

@linamm linamm commented on a1b5273 Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see, it is v4.0.1, that should be fine then. Many thanks!

@jgreen210
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#34

Please sign in to comment.