Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gems): pin concurrent-ruby #2786

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

crherman7
Copy link
Contributor

@crherman7 crherman7 commented Jan 21, 2025

Describe your changes

This pull request addresses a compatibility issue with the concurrent-ruby gem in the iOS continuous integration (CI) pipeline for React Native. The change ensures stability by pinning the concurrent-ruby gem to a version below 1.3.4. This fix is applied to the Gemfile templates for React Native versions 0.72 and 0.73.

Issue ticket number and link

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Test Plan

To test this change:

  1. Ensure that the Gemfile updates are reflected in the iOS CI pipeline configuration for React Native versions 0.72 and 0.73.
  2. Run the CI pipeline to verify that the concurrent-ruby gem version is successfully pinned and no longer causes errors.
  3. Confirm that other gem dependencies are unaffected and that the pipeline completes successfully.

Checklist before requesting a review

  • A self-review of my code has been completed.
  • Tests have been added / updated if required.
  • Documentation has been updated to reflect these changes, where necessary.

@crherman7 crherman7 marked this pull request as draft January 21, 2025 16:48
@crherman7
Copy link
Contributor Author

needs hotfix branch

@crherman7 crherman7 changed the base branch from main to develop January 21, 2025 17:51
@crherman7
Copy link
Contributor Author

needs hotfix branch

Per @NickBurkhartBB, develop will not cause issues to release from.

@crherman7
Copy link
Contributor Author

  * concurrent-ruby (1.3.3)
        Summary: Modern concurrency tools for Ruby. Inspired by Erlang, Clojure, Scala, Haskell, F#, C#, Java, and classic concurrency patterns.
        Homepage: http://www.concurrent-ruby.com
        Source Code: https://github.com/ruby-concurrency/concurrent-ruby
        Changelog: https://github.com/ruby-concurrency/concurrent-ruby/blob/master/CHANGELOG.md
        Path: /opt/homebrew/lib/ruby/gems/3.3.0/gems/concurrent-ruby-1.3.3
        Reverse Dependencies: 
                activesupport (7.0.8.7) depends on concurrent-ruby (~> 1.0, >= 1.0.2)
                cocoapods-core (1.15.2) depends on concurrent-ruby (~> 1.1)
                i18n (1.14.7) depends on concurrent-ruby (~> 1.0)
                tzinfo (2.0.6) depends on concurrent-ruby (~> 1.0)

@crherman7 crherman7 force-pushed the fix/ENG-6006 branch 3 times, most recently from 08b6b55 to 830829f Compare January 21, 2025 18:18
@crherman7 crherman7 marked this pull request as ready for review January 21, 2025 18:26
@NickBurkhartBB NickBurkhartBB merged commit 9d02da1 into brandingbrand:develop Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants