feat(code): ENG-5057 add deprecated plugins #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crherman7
force-pushed
the
feat/deprecated-plugins
branch
3 times, most recently
from
f3f5dea to
c7972cf
Compare
crherman7
force-pushed
the
feat/deprecated-plugins
branch
2 times, most recently
from
ad83339 to
f05d20c
Compare
crherman7
force-pushed
the
feat/deprecated-plugins
branch
3 times, most recently
from
99c8187 to
535c4dc
Compare
crherman7
force-pushed
the
feat/deprecated-plugins
branch
from
535c4dc to
a0f333c
Compare
crherman7
commented
Apr 2, 2024
| @@ -140,6 +140,9 @@ type ManifestProviderAttributes = { | |||
|
|
|||
| /** "writePermission" attribute for the provider. */ | |||
| "android:writePermission"?: string; | |||
|
|
|||
| /** "exorted" attribute for the provider. */ | |||
| "android:exported"?: boolean; | |||
There was a problem hiding this comment.
will need to add this back to v13
| @@ -79,7 +79,14 @@ describe("plugin-splash-screen", () => { | |||
| ); | |||
| } | |||
|
|
|||
| project.addPbxGroup([], "Resources", '""'); | |||
| if (!project.findPBXGroupKey({ name: "Resources" })) { | |||
There was a problem hiding this comment.
probably worth adding this to v13 as it's a safer check and adds it to the main group
| * already created it. This would otherwise error out with vague message. | ||
| */ | ||
| project.addPbxGroup([], "Resources", '""'); | ||
| if (!project.findPBXGroupKey({ name: "Resources" })) { |
There was a problem hiding this comment.
probably worth adding this to v13 as it's a safer check and adds it to the main group
crherman7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add deprecated plugins and unit tests:
Issue ticket number and link
Ticket
Type of change
Test Plan
Checklist before requesting a review