Skip to content

Changes towards modularity#146

Open
sergeyt wants to merge 6 commits intobramp:masterfrom
sergeyt:modularity
Open

Changes towards modularity#146
sergeyt wants to merge 6 commits intobramp:masterfrom
sergeyt:modularity

Conversation

@sergeyt
Copy link
Copy Markdown

@sergeyt sergeyt commented Jan 13, 2016

  • changes in favor of explicit dependencies, i.e. require raphael and lodash
  • support of webpack work flow
  • include fixes of issues for latest lodash 4.0
  • build using webpack instead of preprocessor

This change is Reviewable

@sergeyt sergeyt changed the title [WIP] initial changes towards modularity Changes towards modularity Jan 14, 2016
@sergeyt
Copy link
Copy Markdown
Author

sergeyt commented Jan 14, 2016

@bramp this PR is ready to merge, please consider to merge it and publish the package on npm.

@ntotten
Copy link
Copy Markdown

ntotten commented Jan 21, 2016

I would like to see this as well. Both removing the dependency and adding npm.

@wollnyst
Copy link
Copy Markdown

I agree. Very nice, modern setup.

Small addition, in devserver.js the static middleware must be placed after the webpack-middleware.
Otherwise you'll break up dev-mode, if there's a build\sequence-diagram.js on the disk.

So put

app.use(express.static(process.cwd()));

after:

app.use(require('webpack-dev-middleware')(compiler, {
    noInfo: true,
    publicPath: config.output.publicPath,
}));

app.use(require('webpack-hot-middleware')(compiler));

@sergeyt
Copy link
Copy Markdown
Author

sergeyt commented Jan 24, 2016

@wollnyst thanks for tip about dev-mode, fixed!

@dcousens
Copy link
Copy Markdown

include fixes of issues for latest lodash 4.0

Would be great if you included this PR agnostic of the other changes, ref #158

@rparree
Copy link
Copy Markdown

rparree commented Mar 30, 2018

has this effort been abandoned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants