fix: nightly hardening - remote URL credential guard - #19
Open
mouse-value-add wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem\nRemote profile loading accepted URLs with embedded credentials (for example ). Even with HTTPS, this pattern can leak secrets in logs/history and is not needed because token auth already exists in fetch options.\n\n## Approach\n- Added an early validation guard in to reject URLs that include or components.\n- Return a deterministic with message: .\n- Added a unit test to verify credentialed URLs are rejected before any network call is attempted.\n\n## Verification\n- Ran:
RUN v2.1.9 /Users/mouse/.openclaw/workspace/nightly/you.md
✓ test/parser/loadFromUrl.test.ts (5 tests) 8ms
Test Files 1 passed (1)
Tests 5 passed (5)
Start at 14:45:01
Duration 236ms (transform 34ms, setup 0ms, collect 39ms, tests 8ms, environment 0ms, prepare 27ms)\n- Result: all tests pass (including new credential-guard test).\n\n## Risks\n- Minor behavior change for callers currently relying on credentialed URLs. Those calls now fail fast with explicit guidance.\n\n## Rollback plan\n- Revert commit to restore previous behavior.\n