fix: nightly hardening - strict ISO date validation - #18
Open
mouse-value-add wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
you.mdmetadata date validation accepted impossible calendar dates like2025-02-30and invalid timestamps like2025-01-01T25:00:00Zbecause it relied mostly on format regex checks. This can let malformed profile metadata pass validation and weaken downstream reliability.Approach
isValidDateFormatto validate both structure and semantic date correctness.YYYY-MM-DD, validate by round-tripping through UTC date components.Invalid Dateparses.Verification
npm test -- --run test/core/validator.test.tsRisks
Rollback plan
9b1448eif strict validation causes unwanted regressions.isValidDateFormatwhile preserving new tests as guardrails.