Skip to content

fix: nightly hardening - fetch timeout validation - #12

Merged
brainsparker merged 1 commit into
mainfrom
chore/nightly-hardening-20260422-fetch-timeout-validation
Apr 22, 2026
Merged

fix: nightly hardening - fetch timeout validation#12
brainsparker merged 1 commit into
mainfrom
chore/nightly-hardening-20260422-fetch-timeout-validation

Conversation

@mouse-value-add

Copy link
Copy Markdown
Collaborator

Problem

loadFromUrl() accepted any numeric timeout, including invalid values like 0, negatives, or non-finite numbers. That can trigger immediate aborts or unpredictable behavior in remote profile loading.

Approach

  • Added timeout normalization in the parser to enforce sane fetch timeout values.
  • Invalid timeout values now safely fall back to DEFAULT_FETCH_TIMEOUT.
  • Timeout values are floored to integer milliseconds before use.
  • Added a parser test to verify fallback behavior for invalid timeout inputs.

Verification

  • Ran full test suite: npm test --silent (all tests passing).
  • Added test: test/parser/loadFromUrl.test.ts case for invalid timeout fallback.

Risks

  • Minimal behavior change: callers that previously relied on invalid timeout values (for example 0) will now get default timeout behavior.

Rollback Plan

  • Revert commit 3b3b188 to restore prior timeout handling behavior.

@brainsparker
brainsparker merged commit 567a2ef into main Apr 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants