fix: nightly hardening - fetch timeout validation - #12
Merged
brainsparker merged 1 commit intoApr 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
loadFromUrl()accepted any numeric timeout, including invalid values like0, negatives, or non-finite numbers. That can trigger immediate aborts or unpredictable behavior in remote profile loading.Approach
DEFAULT_FETCH_TIMEOUT.Verification
npm test --silent(all tests passing).test/parser/loadFromUrl.test.tscase for invalid timeout fallback.Risks
0) will now get default timeout behavior.Rollback Plan
3b3b188to restore prior timeout handling behavior.