fix: nightly hardening - strict skill config root validation - #11
Open
mouse-value-add wants to merge 1 commit into
Open
fix: nightly hardening - strict skill config root validation#11mouse-value-add wants to merge 1 commit into
mouse-value-add wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The skill installer accepted any valid JSON value as config, including scalars and arrays. That creates brittle behavior when users have malformed-but-parseable config files, and risks mutating an unexpected structure during install/uninstall.
Approach
Verification
RUN v2.1.9 /Users/mouse/.openclaw/workspace/tmp-nightly/you.md
✓ test/parser/yaml.test.ts (12 tests) 3ms
✓ test/core/validator.test.ts (10 tests) 3ms
✓ test/cli/skill.test.ts (10 tests) 8ms
✓ test/core/discovery.test.ts (13 tests) 4ms
✓ test/parser/markdown.test.ts (11 tests) 8ms
✓ test/cli/wizard.test.ts (12 tests) 4ms
✓ test/cli/check.test.ts (4 tests) 9ms
✓ test/core/signals.test.ts (21 tests) 11ms
✓ test/core/parser.test.ts (16 tests) 27ms
✓ test/core/merger.test.ts (4 tests) 2ms
✓ test/parser/frontmatter.test.ts (7 tests) 1ms
✓ test/core/known-sections.test.ts (4 tests) 2ms
✓ test/cli/templates.test.ts (6 tests) 2ms
✓ test/parser/loadFromUrl.test.ts (3 tests) 10ms
✓ test/cli/skill-status.test.ts (1 test) 10ms
✓ test/parser/timeout.test.ts (3 tests) 4ms
✓ test/mcp/server.test.ts (7 tests) 2ms
Test Files 17 passed (17)
Tests 144 passed (144)
Start at 13:32:05
Duration 655ms (transform 341ms, setup 0ms, collect 827ms, tests 109ms, environment 3ms, prepare 788ms)
Risks
Rollback plan