Repository navigation
Added a What's New link and moved the unit tests onto the shared test utilities - #58
Merged
Merged
Conversation
…rain-bbqs/test-utils The footer gains the shared "What's New" link and the modal that renders CHANGELOG.md. main.ts is now measured by coverage and booted through createMainHarness, one test file per boot scenario; the id contract, observer and clipboard stubs come from @brain-bbqs/test-utils. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NyVicxxv1wsaaocr8ovRX6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NyVicxxv1wsaaocr8ovRX6
|
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
CodyCBakerPhD
marked this pull request as ready for review
September 28, 2026 15:50
CodyCBakerPhD
deleted the
claude/common-components-integration-p2vqjv
branch
September 28, 2026 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 5 of the shared-components migration.
@brain-bbqs/uilink and modal (whats-new.css, thehtml/whats-new.htmlfragment,initWhatsNewfed byCHANGELOG.md?raw, and--whats-new-code-bg: var(--chip-bg))./#changelogopens it. Minor bump to 1.5.0.main.tsis no longer excluded from coverage. It boots throughcreateMainHarnessin four scenario files (smoke,#changelogdeep link, file loaded, mediabunny preload failure) and is now at 100%.elements.test.tsusesexpectIdContract(no unregistered ids). The local observer and clipboard fakes are replaced byinstallObserverStub,stubClipboardandinstallExecCommand. Overall coverage is unchanged at 99.9 / 98.05 / 99.87 / 99.97; the app has no thresholds.CLAUDE.mdtakes the sibling apps' rule against mentioning?testin the changelog.Diff against
main(Chromium; widths 375, 800 and 1400; light, dark and OS-dark; states: default, demos and demo loaded): nothing above the footer moved. The only change is the new row, which makes the footer bar 28.8px taller. Up to 1560px the footer is static, so the page grows by that much. Above 1560px the fixed bar grows from 86px to 114px, but the new row stays inside the 220px gutter, and no content overlaps at any scroll position from 1400 to 1920 or on phones from 320 to 414. The modal is laid out like the uploader's (560px wide, same paddings and type sizes); only the app's own font stack, 1.6 line height and palette differ.Original prompt
🤖 Generated with Claude Code
https://claude.ai/code/session_01NyVicxxv1wsaaocr8ovRX6
Generated by Claude Code