Repository navigation
Renamed Report tab to Full Analysis and moved it out of tab row - #17
Merged
Merged
Conversation
The Report tab shared the tab row with the six views of the file, though it was not a seventh place to look but the one control that produces something, and "report" is the word the footer already uses for filing a bug. It is now a button aligned to the right of the content column, with a document/download icon, labelled Full Analysis. What it produces is a document rather than a page of cards: a title block naming the file and its headline facts, a linked contents list, every section in reading order, the ⓘ explainers written out inline (nobody can hover a saved file), and a closing section naming the runs that were not started. It now carries the analyses the report used to leave behind — the container explainer, the bitrate plot, the GOP histogram, the seeking scatter plot, the chroma and faststart notes, and in-browser reencode results. The panel shows that exact document, rendered in an iframe from the same self-contained HTML the new Download HTML button writes and Save as PDF prints, so no preview can disagree with the file. That replaces the old @media print trick of hiding every other element on the page. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WvGm4XZ6b5v5cYujoCaLVE
|
Tip All tests passed and all changes approved!🟢 UI Tests: encoding-helper-playwright: 1 change accepted as baseline |
|
Tip All tests passed and all changes approved!🟢 UI Tests: encoding-helper-storybook: 4 changes accepted as baselines |
|
The document had only the indented text listing the old report used, not the map the Atom Map tab draws. It now carries the map itself: the same lanes, blocks, colors and legend, minus the parts that need a hand (no zoom, no breadcrumb, no hover readout). Each block keeps its offset and size as a title, which still works on hover in the exported HTML, and the label sizing that a ResizeObserver decides on the page is settled while the document is built, since nothing runs inside it later. The text listing stays underneath, because a printed page has no hover to reveal a number with, but it is now capped at 400 boxes with a line saying how many were left out; a fragmented recording has tens of thousands, and the map draws all of them regardless. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WvGm4XZ6b5v5cYujoCaLVE
The map draws every box in the file; the indented listing under it only restated that in words, at one line per box, which on a fragmented recording ran to tens of thousands of them. The map is now the whole of what the atom section says, with each block carrying its own offset and size as a title. The listing was also the oracle the atom-map test compared against, so that test now measures the drawn blocks against the breadcrumb's own count of the boxes the layout covers, which is what catches one going missing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WvGm4XZ6b5v5cYujoCaLVE
Sections whose runs were never started are simply absent now, rather than the document closing with a list of what it does not contain. The panel above the preview still says which runs have to be started by hand for their results to appear. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WvGm4XZ6b5v5cYujoCaLVE
Also fixed a flake the geometry assertions in the new smoke test introduced: the tab bar lives inside #app, which is display:none until a file loads, and an unrendered element has no box, so boundingBox() came back null whenever the measurement won the race against the reveal. It now waits for the bar to be on screen before asking where it is. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WvGm4XZ6b5v5cYujoCaLVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Report tab has been renamed to Full Analysis and repositioned as a standalone button aligned to the right of the content column, rather than as a seventh tab in the row. This better reflects its purpose as a document-generation action rather than a view of the file.
Key changes:
analysisTab.tsmodule that gathers analysis state and builds sections for the documentanalysisDoc.tsmodule that renders sections to HTML, Markdown, and self-contained HTML filesexplainers.tsmodule, used by both the Inspect tab and Full Analysis documentinspectTab.tsto import explainers from the new shared module instead of defining them locallyindex.htmland styled it as a distinct action with a document-with-download icontabs.tsto handle the new button alongside the tab panelsreportTab.tsmodule and its print-only stylingReencodeResulttype to track engine type and both original/encoded sizes for document reportingThe Full Analysis document is rendered three ways from the same sections: as a preview in an iframe, as a downloadable self-contained HTML file, and as a printable PDF via the browser's print dialog. A separate Markdown export is also available for pasting into issues or lab notebooks.
https://claude.ai/code/session_01WvGm4XZ6b5v5cYujoCaLVE