Repository navigation
Added zoom buttons to Compare Quality panes - #15
Merged
Merged
Conversation
Wheel zoom was the only way to change zoom level, which leaves out a plain mouse without a wheel and touch devices. A - / + pair now steps the zoom by 1.5x around the middle of the pane, alongside the existing Fit and Actual Size buttons, and each disables itself at the end of the zoom range. The wheel handler now goes through the same setScale() helper, so the clamp and the anchor math live in one place. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AmNHGwBMYHvL9YonLTMUti
|
Tip All tests passed and all changes approved!🟢 UI Tests: encoding-helper-playwright: 2 tests unchanged |
|
Tip All tests passed and all changes approved!🟢 UI Tests: encoding-helper-storybook: 7 tests unchanged |
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Removed the paragraph of scroll/drag/scrub instructions under the panes and put a Play button at the head of the controls row. It plays the test segment through in real time and doubles as Pause; dragging the slider mid-playback moves the playhead, and playing from the end starts the segment over. Both panes are decoded per frame, so the loop is paced off the wall clock and asks for whichever frame the elapsed time lands on: when decoding cannot keep up it drops frames instead of drifting into slow motion. A frame that will not decode ends playback rather than leaving the button stuck on "Pause", and re-running the comparison stops the previous run's loop. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AmNHGwBMYHvL9YonLTMUti
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added − and + buttons to the zoom controls in the Compare Quality tab, making zoom functionality accessible without a scroll wheel or trackpad.
Key changes:
setScale()to support both wheel and button inputonChangecallback toattachSyncedZoomPan()to sync button disabled states with zoom levelBoth panes continue moving in sync, and zoom behavior remains consistent across input methods.
https://claude.ai/code/session_01AmNHGwBMYHvL9YonLTMUti