fix: pass --sync flag in template-sync tests#1040
Merged
Merged
Conversation
The sync-templates.mjs script requires --sync, SQUAD_SYNC_TEMPLATES=1 env var, or direct invocation (argv.length <= 2) to actually sync. When run from vitest, extra argv entries mean the direct-invocation check fails, so the script silently skips the sync. Pass --sync explicitly in both the beforeAll hook and the script-execution test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add missing dynamic import for skill.ts command (APM integration). The cli-command-wiring test expects all commands in cli/commands/ to have a corresponding import in cli-entry.ts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bradygaster
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The \ emplate-sync.test.ts\ tests fail on main because \sync-templates.mjs\ requires an explicit --sync\ flag (or \SQUAD_SYNC_TEMPLATES=1\ env var, or direct invocation with \�rgv.length <= 2). When run from vitest, extra argv entries mean the direct-invocation check fails, so the script silently skips the sync — causing byte-comparison assertions to fail.
This was the one remaining fix from #1031 that didn't land before merge.
Fix
Pass --sync\ explicitly in both:
Testing