fix: remove unsafe restart action - #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.1.2-rc.1.taskkillsupport and platform-neutral Stop wording.Root cause
PortDoc restarted the process listening on a port, but supervised development servers can expose a child process rather than the process supervisor. In live Linux testing, PortDoc left the watcher tree behind and launched a non-equivalent replacement attached to PortDoc's terminal. Generic relaunch is not safe without an explicit supervisor or project launch contract.
Impact
The dashboard returns to Stop-only service control.
v0.1.2-rc.1remains an immutable failed prerelease. A future background-management feature will be designed separately.Validation
cargo fmt --checkcargo test(101 passed)cargo clippy -- -D warningsnpm run lintinweb/npm run buildinweb/The pull request CI matrix should validate Ubuntu, macOS, and Windows before merge.