Skip to content

Fix error: multiple definition of `disctype';#16

Open
aphex3k wants to merge 4 commits intobradenmcd:masterfrom
aphex3k:master
Open

Fix error: multiple definition of `disctype';#16
aphex3k wants to merge 4 commits intobradenmcd:masterfrom
aphex3k:master

Conversation

@aphex3k
Copy link
Copy Markdown

@aphex3k aphex3k commented Jan 27, 2023

Fix error

multiple definition of `disctype'; CMakeFiles/friidumplibdir/disc.c.o:(.bss+0x0): first defined here
collect2: error: ld returned 1 exit status

Fixes #10

Michael Henke and others added 4 commits January 27, 2023 15:54
@aphex3k
Copy link
Copy Markdown
Author

aphex3k commented Jan 28, 2023

Also adds a fairly minimal Dockerfile to build and run friidump.

@ColleagueRiley
Copy link
Copy Markdown

You could also just make the uisctype variable static instead of just removing it. I think that matches what the original author was trying to go for more. Although I don't see much of a use of it being there myself, I've not looked much into the code.

@vorburger vorburger mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to Build

2 participants