fix(build): add RUSTFLAGS for tests to allow duplicate symbols from ibkrun.a#437
Open
uran0sH wants to merge 1 commit intoboxlite-ai:mainfrom
Open
fix(build): add RUSTFLAGS for tests to allow duplicate symbols from ibkrun.a#437uran0sH wants to merge 1 commit intoboxlite-ai:mainfrom
uran0sH wants to merge 1 commit intoboxlite-ai:mainfrom
Conversation
…ibkrun.a libkrun.a static library contains Rust stdlib symbols (rust_eh_personality, std::sys::args, etc.). When tests link against it with krun feature enabled, linker encounters duplicate symbols. Add --allow-multiple-definition to RUSTFLAGS in make/test.mk so that make test:all and related targets work correctly. Note: build-shim.sh already has this flag as it sets its own RUSTFLAGS. Signed-off-by: Wenyu Huang <huangwenyuu@outlook.com>
uran0sH
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libkrun.a static library contains Rust stdlib symbols (rust_eh_personality, std::sys::args, etc.). When tests link against it with krun feature enabled, linker encounters duplicate symbols.
Add --allow-multiple-definition to RUSTFLAGS in make/test.mk so that make test:all and related targets work correctly.
Note: build-shim.sh already has this flag as it sets its own RUSTFLAGS.