Skip to content

fix(item-details): Ensure "Extend" is beside disposition date in sidebar #3940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(item-details): Ensure "Extend" is beside disposition date in sidebar #3940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b5e871
fix(item-details): Ensure "Extend" is beside disposition date in sidebar
sten-box Feb 18, 2025
37f3bd1
Merge branch 'master' into fix-retention-extend-link
sten-box Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/features/item-details/ItemProperties.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@
background-color: transparent;
border-color: transparent;
box-shadow: none;
transition: background-color .2s, border-color .2s, margin-left .2s, padding .2s;
transition:
background-color .2s,
border-color .2s,
margin-left .2s,
padding .2s;
resize: none;

&:hover {
Expand All @@ -48,7 +52,10 @@
padding: 0;
border: none;
box-shadow: none;
transition: border .2s, height .2s, padding .2s;
transition:
border .2s,
height .2s,
padding .2s;

&:focus {
height: 32px;
Expand All @@ -59,6 +66,7 @@
}

.bdl-RetentionLink {
display: inline;
margin-left: 4px;
}

Expand Down
13 changes: 13 additions & 0 deletions src/features/item-details/__tests__/ItemProperties.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,17 @@ describe('features/item-details/ItemProperties', () => {

expect(wrapper).toMatchSnapshot();
});

test('should render retention policy details when specified', () => {
const wrapper = getWrapper({
retentionPolicyProps: {
dispositionTime: 1741475146,
openModal: () => {},
policyType: 'finite',
retentionPolicyDescription: 'Test Description',
},
});

expect(wrapper).toMatchSnapshot();
});
});
13 changes: 13 additions & 0 deletions src/features/item-details/__tests__/__snapshots__/ItemProperties.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,3 +214,16 @@ exports[`features/item-details/ItemProperties should render readonly url when on
<RetentionPolicy />
</dl>
`;

exports[`features/item-details/ItemProperties should render retention policy details when specified 1`] = `
<dl
className="item-properties"
>
<RetentionPolicy
dispositionTime={1741475146}
openModal={[Function]}
policyType="finite"
retentionPolicyDescription="Test Description"
/>
</dl>
`;