feat: add bounding box highlight UI components and types#738
Merged
Lindar90 merged 3 commits intobox:masterfrom Mar 18, 2026
Merged
feat: add bounding box highlight UI components and types#738Lindar90 merged 3 commits intobox:masterfrom
Lindar90 merged 3 commits intobox:masterfrom
Conversation
- Add BoundingBoxHighlightRect, BoundingBoxHighlightNav, BoundingBoxHighlightList - Add BoundingBox type and component styles - Add ChevronLeft and ChevronRight icons - Add messages for aria labels - Add comprehensive unit tests for all components Made-with: Cursor feat: update tests feat: update tests feat: move bboxes under components feat: rename directory
|
|
Lindar90
reviewed
Mar 17, 2026
Lindar90
left a comment
Lindar90
left a comment
There was a problem hiding this comment.
I left a couple of questions and minor notes
src/components/BoundingBoxHighlight/BoundingBoxHighlightList.tsx
Outdated
Show resolved
Hide resolved
src/components/BoundingBoxHighlight/BoundingBoxHighlightList.tsx
Outdated
Show resolved
Hide resolved
src/components/BoundingBoxHighlight/BoundingBoxHighlightRect.tsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR introduces UI components necessary for supporting Bounding Box functionality as part of Box Annotations.
Next steps: Next PR will introduce state and flag management.