refactor(bounty-card): remove unsafe Bounty casts for slot counts

[abimbolaalabi]

Closes #273

refactor(bounty-card): remove unsafe Bounty casts for slot counts

Replace the ad-hoc (bounty as unknown as Bounty) casts with a dedicated
CardBounty type that extends BountyFieldsFragment with the optional
totalSlotsOccupied and maxSlots fields.

Changes:

• Introduce CardBounty for BountyCardProps
• Remove unsafe casts when reading slot count values
• Remove unused Bounty import
• Preserve type safety without relying on Partial<Bounty>

Validation:

• npx tsc --noEmit passes
• npx eslint components/bounty/bounty-card.tsx passes with no warnings
• No remaining (bounty as unknown as Bounty) or object-literal casts in
  components/bounty/ (except the existing session?.user casts)

Summary by CodeRabbit

• Bug Fixes
  • Improved the bounty card’s slot count display so milestone badges show the correct occupied and total slots, with safer fallback values when data is missing.

[vercel]

@abimbolaalabi is attempting to deploy a commit to the Threadflow Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 79a2cf16-73a3-4ba1-a2cb-803ba06c1b1c

📥 Commits

Reviewing files that changed from the base of the PR and between 128d423 and a79bb49.

📒 Files selected for processing (1)

• components/bounty/bounty-card.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

• components/bounty/bounty-card.tsx

---

📝 Walkthrough

Walkthrough

Updates bounty-card.tsx to type its bounty prop with optional slot-count fields and to read totalSlotsOccupied and maxSlots directly when rendering the multi-winner milestone badge.

Changes

Bounty card slot typing

Layer / File(s)	Summary
Prop typing and slot badge components/bounty/bounty-card.tsx	Adds a local bounty type with optional slot-count fields, updates the prop type to use it, and uses those fields directly in the multi-winner milestone badge.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

• boundlessfi/bounties#17 — Both changes touch components/bounty/bounty-card.tsx and its bounty-field display logic.
• boundlessfi/bounties#263 — Both changes align on nullable slot-count fields in the bounty UI and direct optional-field access.

Suggested reviewers

• Benjtalkshow

Poem

A bunny hopped through type-safe grass,
To count the slots with graceful class.
No cast, no fuss, just fields that gleam —
A tidy badge and carrot dream 🐰

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: removing unsafe Bounty casts from bounty-card slot counts.
Linked Issues check	✅ Passed	The change removes the unsafe slot-count casts, widens the prop type, and matches the linked issue’s acceptance criteria.
Out of Scope Changes check	✅ Passed	No unrelated code changes are indicated beyond the targeted bounty-card refactor and minor formatting cleanup.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[drips-wave]

@abimbolaalabi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[Benjtalkshow]

Looks clean and the casts are gone, but the new CardBounty type diverges from
the pattern the rest of the bounty surface uses. Also attach a screenshot of the CardBounty in your PR. Four other components widen
their prop type the same way:

• components/bounty/submission-approval-panel.tsx:31
• components/bounty-detail/use-bounty-cta-state.ts:16
• components/bounty-detail/bounty-detail-sidebar-cta.tsx:40
• components/bounty-detail/bounty-detail-mobile-cta.tsx:26

All four use BountyFieldsFragment & Partial<Bounty>. Could you switch
CardBounty to that shape so all bounty card/detail components stay
consistent? The issue (#273) explicitly mentions this pattern.

After that change is in, this is good to merge.

[abimbolaalabi]

Changes applied to components/bounty/bounty-card.tsx:

1. Line 16 — Added import type { Bounty } from "@/types/bounty"
2. Line 21 — CardBounty changed from custom explicit fields to BountyFieldsFragment & Partial (matching the pattern in submission-approval-panel.tsx, use-bounty-cta-state.ts, bounty-detail-sidebar-cta.tsx, bounty-detail-mobile-cta.tsx)
3. Line 27 — BountyCardProps.bounty changed to BountyFieldsFragment (callers pass fragment data from list queries)
4. Line 100 — Added const cardBounty = bounty as CardBounty (single internal cast at the component boundary, same approach as useBountyDetail's cast)
5. Line 236 — Slot count access uses cardBounty.totalSlotsOccupied / cardBounty.maxSlots instead of bounty.as unknown as Bounty casts

[coderabbitai]

🧹 Nitpick comments (1)

components/bounty/bounty-card.tsx (1)

22-25: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win

Widen BountyCardProps.bounty to the slot fields this component reads. BountyFieldsFragment still doesn’t include totalSlotsOccupied or maxSlots, so the as CardBounty cast remains. Narrow the prop type to those two optional fields instead of Partial<Bounty>.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@components/bounty/bounty-card.tsx` around lines 22 - 25, The
BountyCardProps.bounty type is still too narrow for the fields read by
BountyCard, which is why the CardBounty cast is still needed. Update
BountyCardProps to include the slot fields actually consumed by the component,
specifically totalSlotsOccupied and maxSlots as optional fields, and remove the
broader Partial<Bounty> dependency from CardBounty so the cast can be eliminated
cleanly.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@components/bounty/bounty-card.tsx`:
- Around line 22-25: The BountyCardProps.bounty type is still too narrow for the
fields read by BountyCard, which is why the CardBounty cast is still needed.
Update BountyCardProps to include the slot fields actually consumed by the
component, specifically totalSlotsOccupied and maxSlots as optional fields, and
remove the broader Partial<Bounty> dependency from CardBounty so the cast can be
eliminated cleanly.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ea8ac7c7-8aee-4235-a458-5f807a32b622

📥 Commits

Reviewing files that changed from the base of the PR and between 81aa5c0 and 128d423.

📒 Files selected for processing (1)

• components/bounty/bounty-card.tsx

[Benjtalkshow]

Changes applied to components/bounty/bounty-card.tsx:

1. Line 16 — Added import type { Bounty } from "@/types/bounty"
2. Line 21 — CardBounty changed from custom explicit fields to BountyFieldsFragment & Partial (matching the pattern in submission-approval-panel.tsx, use-bounty-cta-state.ts, bounty-detail-sidebar-cta.tsx, bounty-detail-mobile-cta.tsx)
3. Line 27 — BountyCardProps.bounty changed to BountyFieldsFragment (callers pass fragment data from list queries)
4. Line 100 — Added const cardBounty = bounty as CardBounty (single internal cast at the component boundary, same approach as useBountyDetail's cast)
5. Line 236 — Slot count access uses cardBounty.totalSlotsOccupied / cardBounty.maxSlots instead of bounty.as unknown as Bounty casts

Good progress — CardBounty now matches the project pattern and local CI is clean. One step before merge: widen the prop itself to CardBounty so the internal bounty as CardBounty cast (and the cardBounty local) can go away. The four sibling files all type the bounty prop as the widened type:

• components/bounty-detail/bounty-detail-sidebar-cta.tsx:40
• components/bounty-detail/bounty-detail-mobile-cta.tsx:26
• components/bounty/submission-approval-panel.tsx:31
• components/bounty-detail/use-bounty-cta-state.ts:16

Apply the same here:

interface BountyCardProps {
  bounty: CardBounty;  // was BountyFieldsFragment
  ...
}
// drop: const cardBounty = bounty as CardBounty;
// use bounty.totalSlotsOccupied / bounty.maxSlots directly

After that, please attach a screenshot of the bounty card showing the slot-count badge on a MULTI_WINNER_MILESTONE bounty so I can confirm the visual is unchanged. Then ready to merge.

[Benjtalkshow]

LGTM!