Skip to content

controller: Prevent existing log group from stopping log retention #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

controller: Prevent existing log group from stopping log retention #889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions controller/src/job/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use k8s_openapi::api::core::v1::Pod;
use k8s_openapi::chrono::{Duration, Utc};
use kube::api::{DeleteParams, ListParams, LogParams, PropagationPolicy};
use kube::{Api, ResourceExt};
use log::{debug, info, warn};
use log::{debug, info, trace, warn};
use snafu::{ensure, OptionExt, ResultExt};
use std::env;
use std::time::{SystemTime, UNIX_EPOCH};
Expand Down Expand Up @@ -206,15 +206,16 @@ pub(crate) async fn archive_logs(k8s_client: kube::Client, job_name: &str) -> Jo
SystemTime::now().duration_since(UNIX_EPOCH)?.as_secs()
);

client
if client
.create_log_stream()
.log_group_name("testsys")
.log_stream_name(&name)
.send()
.await
.context(error::CreateLogStreamSnafu {
log_stream: name.to_string(),
})?;
.is_err()
{
trace!("Unable to create log group it is possible it already exists.");
Copy link
Contributor

@webern webern Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things, you should log the error with {:?}.
You should check for the specific "it already exists" error condition and only ignore that, otherwise issues like authorization, etc could be difficult to diagnose.

}

client
.put_log_events()
Expand Down