chore(cli): gofmt agent_bundle.go struct-literal indentation (ag-tcf0.2 #gofmt-agent-bundle)#783
Merged
Merged
Conversation
….2 #gofmt-agent-bundle) agent_bundle.go had an extra-tab indent on the Bootstrap field of the codex-ntm bundle struct literal, unformatted since df3cc98. CI's golangci-lint runs default linters (gofmt formatter excluded), so the drift landed on main undetected. Whitespace-only; behavior unchanged. Closes-scenario: ag-tcf0.2#gofmt-agent-bundle Bounded-context: BC5-Runtime Evidence: gofmt -l cli/ clean; go build/vet ok; 8 bundle tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a gofmt drift that landed on
main:cmd/ao/agent_bundle.gohad an extra-tab indent on theBootstrapfield of the codex-ntm bundle struct literal (unformatted since df3cc98, ~24h ago). Whitespace-only — theBootstrapstring value is unchanged, behavior identical.Why it slipped through
CI runs
golangci-lint runwith default linters, which exclude thegofmtformatter, so source-formatting drift is not gated and lands onmainundetected. This is the same class as the ag-tcf0 audit "14 files unformatted" finding; the earlier sweep (ag-ozac) fixed files but did not add an enforcement gate. The missing gofmt CI gate is drafted to the operator queue (it interacts with the gate-target/path-filter system and the active ag-tcf0.1 golangci worktree, so it warrants operator confirmation rather than a unilateral CI-gate change).Test
The paired
agent_bundle_test.gochange strengthens the existingBootstrapsubstring assertion to exact equality (per.claude/rules/go.md: "assert exact expected values, not just substring"), guarding the struct literal against silent drift at the exact site of the fix.gofmt -l cli/cleango build ./...,go vet ./cmd/ao/okgo test ./cmd/ao/ -run TestBuildAgentBundle_CodexNTMpass (8 bundle tests green)scripts/pre-push-gate.sh --fastpassedCloses-scenario: ag-tcf0.2#gofmt-agent-bundle
Bounded-context: BC5-Runtime
Evidence: pre-push-gate --fast passed; gofmt -l clean; bundle tests green