Merge pull request COVESA#23 from adriaan-niess/improve/cvf

Fix CVF talker and improve documentation
boschglobal · Jul 29, 2024 · 2da7035 · 2da7035
2 parents e547f4f + e790211
commit 2da7035
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/examples/cvf/README.md b/examples/cvf/README.md
@@ -15,7 +15,7 @@ The easiest way to use this example is by combining it with a GStreamer pipeline
 
 ```
 $ cvf-listener <args> | gst-launch-1.0 filesrc location=/dev/stdin \
-  ! decodebin ! videoconvert ! autovideosink
+  ! h264parse ! avdec_h264 ! videoconvert ! autovideosink
 ```
 
 ## CVF Talker
@@ -35,4 +35,4 @@ $ gst-launch-1.0 -e -q videotestsrc pattern=ball \
   ! video/x-h264,stream-format=byte-stream ! filesink location=/dev/stdout \
   | cvf-talker <args>
 ```
-Note that the `x264enc` may be changed by any other H.264 encoder available, as long as it generates a byte-stream with NAL units no longer than 1400 bytes.
+Note that the `x264enc` may be changed by any other H.264 encoder available, as long as it generates a byte-stream with NAL units no longer than 1400 bytes.
diff --git a/examples/cvf/cvf-listener.c b/examples/cvf/cvf-listener.c
@@ -54,7 +54,7 @@
  * display, you can do something like:
  *
  * $ cvf-listener <args> | gst-launch-1.0 filesrc location=/dev/stdin \
- *  ! decodebin ! videoconvert ! autovideosink
+ *    ! h264parse ! avdec_h264 ! videoconvert ! autovideosink
  */
 
 #include <assert.h>

diff --git a/examples/cvf/cvf-talker.c b/examples/cvf/cvf-talker.c
@@ -141,6 +141,7 @@ static int init_pdu(Avtp_Cvf_t* cvf)
 {
     Avtp_Cvf_Init(cvf);
     Avtp_Cvf_SetField(cvf, AVTP_CVF_FIELD_FORMAT_SUBTYPE, AVTP_CVF_FORMAT_SUBTYPE_H264);
+    Avtp_Cvf_SetField(cvf, AVTP_CVF_FIELD_FORMAT, AVTP_CVF_FORMAT_RFC);
     Avtp_Cvf_SetField(cvf, AVTP_CVF_FIELD_TV, 1);
     Avtp_Cvf_SetField(cvf, AVTP_CVF_FIELD_STREAM_ID, STREAM_ID);
     Avtp_Cvf_SetField(cvf, AVTP_CVF_FIELD_M, 1);