Skip to content

Initial implementation for crop center selector, #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 31, 2025
Merged

Conversation

zarya
Copy link
Collaborator

@zarya zarya commented May 6, 2025

Initial implementation for crop center selector, js grinder added crop center feature

Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 30.90909% with 38 lines in your changes missing coverage. Please review.

Project coverage is 83.12%. Comparing base (528c018) to head (43df60b).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/files/views.py 27.27% 24 Missing ⚠️
src/files/mixins.py 28.57% 10 Missing ⚠️
src/jobs/models.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #371      +/-   ##
===========================================
- Coverage    83.75%   83.12%   -0.64%     
===========================================
  Files          148      148              
  Lines         4155     4207      +52     
===========================================
+ Hits          3480     3497      +17     
- Misses         675      710      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 63.63636% with 20 lines in your changes missing coverage. Please review.

Project coverage is 82.83%. Comparing base (98ce86a) to head (dca5b5e).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/files/views.py 69.69% 10 Missing ⚠️
src/files/mixins.py 57.14% 6 Missing ⚠️
src/jobs/models.py 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #371      +/-   ##
===========================================
- Coverage    83.03%   82.83%   -0.21%     
===========================================
  Files          118      118              
  Lines         4009     4061      +52     
===========================================
+ Hits          3329     3364      +35     
- Misses         680      697      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zarya zarya marked this pull request as ready for review May 30, 2025 11:53
Comment on lines 2 to 7
// remove the .noscript class from <body>
// this allows us to add the class .hide-for-nojs-users to any element as needed
$('body,html').removeClass("no-js");

// enable all js tooltips on the page
$('[data-bs-toggle="tooltip"]').tooltip();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these lines included on purpose?

Copy link
Member

@tykling tykling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a singe question

@tykling tykling merged commit 10f0c2e into develop May 31, 2025
2 of 4 checks passed
@tykling tykling deleted the crop_center branch May 31, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants