-
Notifications
You must be signed in to change notification settings - Fork 158
index: add VPP repository #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi and thanks for your contribution @nplanelcisco! We don't use VPP at Bootlin but we already index DPDK that lives in the same space. We aren't against adding VPP if it is helpful to others. I'd have (a few) questions:
Thanks! |
Yes I a quick test locally, thanks to the index tool
It's not mandatory it's in the extras/ directory
It's not mandatory, would be a plus as our build chain is based on cmake, meson and ninja
Thanks I will test locally and update this PR
Thanks I will test locally and update this PR
Most of the VPP code is useful by itself as it introduce vectoring principle with different software layers like vpp infra, vlib, vnet. One our plugin (DPDK) have a dependency on DPDK that you host already. |
Thanks for answering exhaustively.
My initial thought was "oh no". Actually, if it is really useful, then we could possibly do it. Here is a brain dump of what it would look like:
That's doable, but it is really low in our priority list. If someone wants to invest some of their time working on that feature, we can talk. |
@tleb thanks for the advice, I will take a look in another PR Let's merge this one if you are ok, as it's do 99% of the jobs with referencing internal includes thanks to cpppathinc filter. |
@tleb ping |
I tested this patch locally and I don't have much more to add. You may want to replace |
@fstachura Query class doesn't have the file_exists() method (even in prod branch) or I missing something ? |
eb432b6
to
3672b9d
Compare
@nplanelcisco Query class refactor was merged some time ago |
FD.io's Vector Packet Processor (VPP) is a fast, scalable layer 2-4 multi-platform network stack. It runs in Linux Userspace on multiple architectures including x86, ARM, and Power architectures. VPP's high performance network stack is quickly becoming the network stack of choice for applications around the world. Signed-off-by: Nicolas PLANEL <[email protected]> Signed-off-by: Nicolas PLANEL <[email protected]>
3672b9d
to
3be5c76
Compare
thanks, sorry for the noise |
FD.io's Vector Packet Processor (VPP) is a fast, scalable layer 2-4 multi-platform network stack. It runs in Linux Userspace on multiple architectures including x86, ARM, and Power architectures.
VPP's high performance network stack is quickly becoming the network stack of choice for applications around the world.