-
Notifications
You must be signed in to change notification settings - Fork 17
Add "Import new releases" emails (#1872) #1945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
I deleted version 1.89.0 in http://localhost:8000/admin/versions/version/. When I click import new release I get no email but it does import 1.89.0. For the Do It All I'm getting: Am I missing test steps @daveoconnor ? |
I believe "Do It All" is somewhat deprecated. The purpose of that was to also include the Release Report. However there is some other method to handle that now. The publish scripts have been set back to use the original Import Releases button. Email would be expected to fail. if you're not set up with official api keys to mailgun, etc. Perhaps not easily testable then. |
Tested with @daveoconnor Received emails when the tasks start and when they finish. Your task The task Progress Messages The import_commits task did not find commits for these libraries. Your task Progress Messages @GregKaleka @rbbeeston This needs a review from you. @daveoconnor once approved we can merge. Thank you! |
@karimarie67 , in the most recent message "Received emails when the tasks start..."
There's apparently a delay of 12 hrs. Was there a long delay? |
![]() @gregjkal and/or @rbbeeston - this needs review as well. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - nice refactor.
This is related to #1872.
Testing: confirm that the "do it all" and "import new releases" button in the admin versions ui send an email with a list of completed tasks, and list the function for each task, e.g.
2025-10-01 22:02:21.244245+00:00: Task start - function: import_versions, desc: Importing versions...