Skip to content

Conversation

daveoconnor
Copy link
Collaborator

@daveoconnor daveoconnor commented Sep 8, 2025

This includes the following changes, related to ticket #1911:

  • Upgrades Django to 5.2 with code updates.
  • Upgrades Python to 3.13.
  • Adds django-upgrade, as a just command and a pre-commit hook.
  • Adds documentation for dependency upgrade process.
  • Removes unused (and unmaintained) django-rest-auth.
  • Updates github workflows to Python 3.13.

I'm aiming for the 4.2 upgrade to go to prod and then we test this locally for a few days.

@daveoconnor daveoconnor force-pushed the doc/1911-upgrade-django-5n branch from 971740e to 28a8a7f Compare September 8, 2025 23:47
@daveoconnor
Copy link
Collaborator Author

daveoconnor commented Sep 8, 2025

HI @sdarwin, CI actions are failing because server versions of PostgreSQL are <14 (v12).

For local development we've been using v16 in the docker-compose.yml, most recent PostgreSQL is v17, with v18 coming on the 25th of September.

This isn't very urgent, doesn't block Django 4.2 we want out sooner.

@sdarwin
Copy link
Collaborator

sdarwin commented Sep 9, 2025

@sdarwin, CI actions are failing because server versions of PostgreSQL are <14 (v12).

Then in this PR adjust the postgres version (v12) in .github/workflows/actions.yml and .github/workflows/actions-gcp.yaml

The server itself is v16. We should plan to stay on that, upgrading at the same time as the server, which is approximately every 2 yrs with Ubuntu upgrades.

@daveoconnor daveoconnor force-pushed the doc/1911-upgrade-django-5n branch from 28a8a7f to a2ead55 Compare September 9, 2025 15:35
@daveoconnor
Copy link
Collaborator Author

Thanks, was wary of changing those in case that caused issues elsewhere. Done now.

Copy link
Collaborator

@gregjkal gregjkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One small question.

Base automatically changed from doc/1910-upgrade-django-4n to develop September 11, 2025 17:39
@daveoconnor daveoconnor force-pushed the doc/1911-upgrade-django-5n branch from a2ead55 to 11c9ab5 Compare September 25, 2025 23:51
@karimarie67
Copy link
Collaborator

@daveoconnor We discussed this one a while back "that one should be done later, can wait for now. Probably should in fact, would be a couple of weeks before that's going out so should get updated in the meantime". Can this one go now? Thank you!

@daveoconnor
Copy link
Collaborator Author

I'd like to merge this one after a merge to master so we can use it locally for close to a week. If you've QAd it I can merge it after tomorrow's merge.

@daveoconnor daveoconnor force-pushed the doc/1911-upgrade-django-5n branch from 11c9ab5 to 7b375b5 Compare September 30, 2025 15:59
@karimarie67 karimarie67 added the On Hold PR is tested/ready but can't be merged yet label Sep 30, 2025
@daveoconnor daveoconnor force-pushed the doc/1911-upgrade-django-5n branch from 7b375b5 to b2e1726 Compare October 9, 2025 00:53
@daveoconnor daveoconnor force-pushed the doc/1911-upgrade-django-5n branch 2 times, most recently from 5337131 to f909bdd Compare October 16, 2025 18:30
@daveoconnor daveoconnor force-pushed the doc/1911-upgrade-django-5n branch from f909bdd to ab472ab Compare October 17, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

On Hold PR is tested/ready but can't be merged yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants