-
Notifications
You must be signed in to change notification settings - Fork 17
Upgrade django to 5.2, python to 3.13 #1915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
971740e
to
28a8a7f
Compare
HI @sdarwin, CI actions are failing because server versions of PostgreSQL are <14 (v12). For local development we've been using v16 in the docker-compose.yml, most recent PostgreSQL is v17, with v18 coming on the 25th of September. This isn't very urgent, doesn't block Django 4.2 we want out sooner. |
Then in this PR adjust the postgres version (v12) in .github/workflows/actions.yml and .github/workflows/actions-gcp.yaml The server itself is v16. We should plan to stay on that, upgrading at the same time as the server, which is approximately every 2 yrs with Ubuntu upgrades. |
28a8a7f
to
a2ead55
Compare
Thanks, was wary of changing those in case that caused issues elsewhere. Done now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One small question.
a2ead55
to
11c9ab5
Compare
@daveoconnor We discussed this one a while back "that one should be done later, can wait for now. Probably should in fact, would be a couple of weeks before that's going out so should get updated in the meantime". Can this one go now? Thank you! |
I'd like to merge this one after a merge to master so we can use it locally for close to a week. If you've QAd it I can merge it after tomorrow's merge. |
11c9ab5
to
7b375b5
Compare
7b375b5
to
b2e1726
Compare
5337131
to
f909bdd
Compare
f909bdd
to
ab472ab
Compare
This includes the following changes, related to ticket #1911:
django-upgrade
, as ajust
command and a pre-commit hook.django-rest-auth
.I'm aiming for the 4.2 upgrade to go to prod and then we test this locally for a few days.