posix: check glibc version for ::close_range function #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moreover, I've just noticed that kernel version also checked wrong.
#if LINUX_VERSION_CODE >= KERNEL_VERSION(5,9,0) |
…close_range syscall support
|
@klemens-morgenstern I've noticed that you pushed the fix to you devel branch, but you haven't provided option to fully disable close_range usage, as I understood. In case we build on new kernel, BUT with old glibc (for extended compatibility) the whole program will break, because of ENOTSUP error (a.k.a Unsupported system call). |
klemens-morgenstern
added a commit
that referenced
this pull request
Oct 24, 2024
klemens-morgenstern
added a commit
that referenced
this pull request
Oct 24, 2024
klemens-morgenstern
added a commit
that referenced
this pull request
Oct 30, 2024
klemens-morgenstern
force-pushed
the
develop
branch
2 times, most recently
from
ac43b71 to
58586e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On old systems with old glibc, but new kernel (the common case is build in CI on ancient OS with old glibc for extended compatibility) there may not be
::close_range()function. In this case build will fail.To avoid that we should properly check not only linux kernel version, but glibc version too.
There is one another option to solve this issue is use raw system call with only checking kernel version, but it seems to me dirty solution.