Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set pipe size issue322 #324

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Set pipe size issue322 #324

wants to merge 2 commits into from

Conversation

SilverPlate3
Copy link
Contributor

Possible Solution to #322.
Including unit tests.

Please let me know if:

  1. You prefer the API to be part of the bp::opstream/bp::ipstream. So users won't need to go into ip.pipe.set_pipe_capacity().
  2. Would you like me to add it to the doc's?
  3. When could it be pushed in?

@SilverPlate3
set_pipe_capacity
679c170 
set_pipe_capacity & set_pipe_capacity_max work locally.
@SilverPlate3
Unit tests
cd30769 
set_pipe_capacity & set_pipe_capacity_max unit tests. Passes locally
@SilverPlate3 SilverPlate3 mentioned this pull request Jul 1, 2023
Open
@klemens-morgenstern
Copy link
Collaborator

I don't think this should be part of the API. It's linux only , so you can just use fcntl manually. Its trivial, really.

@klemens-morgenstern klemens-morgenstern force-pushed the develop branch 2 times, most recently from ac43b71 to 58586e4 Compare October 30, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SilverPlate3 @klemens-morgenstern