Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's certainly nice that C++ allows you to not have {} to
encapsulate a function body if that body only consists of a single
statement (here:
try{…}
), it is not of any familiarity to C++ codersto omit them.
Same goes for putting
main
's argc/argv arguments on multiple lines.Also, defining a macro PRIVATE_SOMETHING just to use it once one line of
code below is a bit of a strange thing to do.
So, I got rid of the macro and applied the clang-format style from
https://github.com/boost-experimental/vc