Skip to content

Fix -Wdeprecated-copy #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix -Wdeprecated-copy #44

wants to merge 1 commit into from

Conversation

georgthegreat
Copy link 

boost/circular_buffer/include/boost/circular_buffer/details.hpp:263:15: error: definition of implicit copy constructor for 'iterator<boost::circular_buffer<bool>, boost::cb_details::const_traits<std::allocator<bool>>>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
    iterator& operator=(const iterator&) = default;
              ^

@georgthegreat
Fix -Wdeprecated-copy
eeb6c4d 
```
boost/circular_buffer/include/boost/circular_buffer/details.hpp:263:15: error: definition of implicit copy constructor for 'iterator<boost::circular_buffer<bool>, boost::cb_details::const_traits<std::allocator<bool>>>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
    iterator& operator=(const iterator&) = default;
              ^
```
@georgthegreat
Copy link
Author

I think that compiler-generated assignment operator should work as intended.

@CamJN
Copy link

CamJN commented Feb 13, 2024

Just commenting in the hopes this gets looked at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgthegreat @CamJN