Update fuzzing seed-corpus generation #256
Conversation
|
Ping @grafikrobot in case he has any feedback on the Jam part. This looks quite involved for just running a Python script in Jam but I didn't found anything better. |
fuzzing/Jamfile
Outdated
|
|
||
| # Create the output corpus directories | ||
| make /tmp/corpus/$(fuzzer) : : common.MkDir ; | ||
| make /tmp/mincorpus/$(fuzzer) : : common.MkDir ; | ||
| make $(corpus) : $(seed_files) : make-corpus ; |
There was a problem hiding this comment.
I like adding a dependency to the script make rules run. As it reruns the targets if it's only the script that changes.
There was a problem hiding this comment.
I'm not sure what you mean by this, or how to implement the suggestion
There was a problem hiding this comment.
Would that be this?
| make $(corpus) : $(seed_files) : make-corpus ; | |
| make $(corpus) : $(seed_files) : make-corpus <dependency> $(.make-corpus-script) ; |
BTW: Does it automatically add a dependency on the input files?
There was a problem hiding this comment.
@Flamefire yes that would be it. And yes, the make rule adds dependencies for inputs (all B2 rules do).
There was a problem hiding this comment.
Oops.. There should be an additional : there.. make-corpus : <dependency> $(.make-corpus-script)
There was a problem hiding this comment.
This is giving the error
error: '/home/runner/work/charconv/boost-root/libs/charconv/fuzzing/make-corpus.py' is not a valid property specification
https://github.com/boostorg/charconv/actions/runs/12792451062/job/35662937747?pr=256#step:7:44
There was a problem hiding this comment.
There shouldn't be a space in the dependency. It should be <dependency>$(.make-corpus-script).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #256 +/- ##
========================================
Coverage 94.85% 94.85%
========================================
Files 69 69
Lines 9077 9077
========================================
Hits 8610 8610
Misses 467 467 Continue to review full report in Codecov by Sentry.
|
|
@Flamefire have you seen these directory not found errors in Locale? They seem sporadic |
Thanks to @Flamefire for providing this fix. Right now we have one file with many lines, but this breaks it into many files with one line each to better seed the fuzzer.