Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boost min/max guidelines violations #254

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Fix boost min/max guidelines violations #254

merged 1 commit into from
Jan 3, 2025

Conversation

mborland
Copy link
Member

@mborland mborland commented Jan 3, 2025

Closes: #251

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.85%. Comparing base (25dfbce) to head (e52759e).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #254   +/-   ##
========================================
  Coverage    94.85%   94.85%           
========================================
  Files           69       69           
  Lines         9077     9077           
========================================
  Hits          8610     8610           
  Misses         467      467           
Files with missing lines Coverage Δ
include/boost/charconv/detail/emulated128.hpp 100.00% <ø> (ø)
...nclude/boost/charconv/detail/fallback_routines.hpp 84.61% <ø> (ø)
.../boost/charconv/detail/fast_float/parse_number.hpp 92.18% <ø> (ø)
src/from_chars_float_impl.hpp 82.97% <ø> (ø)
test/from_chars.cpp 100.00% <100.00%> (ø)
test/limits.cpp 100.00% <100.00%> (ø)
test/roundtrip.cpp 98.75% <100.00%> (ø)
test/test_128bit_emulation.cpp 100.00% <100.00%> (ø)
test/test_128bit_native.cpp 100.00% <100.00%> (ø)
test/test_parser.cpp 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25dfbce...e52759e. Read the comment docs.

@mborland mborland merged commit dacb62a into develop Jan 3, 2025
70 checks passed
@mborland mborland deleted the min_max branch January 3, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix MIN/MAX violations
1 participant