-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for modular build structure. #21
base: develop
Are you sure you want to change the base?
Conversation
You'll have to walk me through these changes and explain why each is needed.
|
As the PR is tied to the branch I'm developing in I need those changes. As otherwise there's no way for me to test that things are working as expected and without regressions. They are harmless though. :-)
Okay. I was being consistent with all the other changes in libs/tools I'm making. But I can change it to be old-skool.
To be consistent I'm adding an "all", and other targets. I still need to write up an explanation of those in README.md though.
I can probably remove that. It was just easier to debug building when I didn't have to worry about DLL linking at one point.
To be notionally consistent with the project root declaring public targets. Hence equivalently to cmake. |
Forgot to answer this one..
It's not, but it works. But it's also now better than it used to be. As before it was done different for each of the tools. Ideally we should use the https://www.bfgroup.xyz/b2/manual/release/index.html#bbv2.builtin.features.install-prefix features. But I didn't want to go risking breaking things more than I had to. |
If we copy-paste the same DISTDIR logic everywhere, it will eventually deviate and we'll be back to status quo. |
You can keep these in your fork; I don't need them here. |
I reworked the logic to avoid mentioning "modular" except for the single branch filter at the top. We can remove that single mention in a future change. |
Did that. |
That's also done. Anything else? |
This still contains changes to ci.yml that I'm not willing to accept. |
This is part of the effort to make the Boost libraries "modular" for build and consumption. See https://lists.boost.org/Archives/boost/2024/01/255704.php and https://github.com/grafikrobot/boost-b2-modular/blob/b2-modular/README.adoc for more information.
This PR depends on the following other PRs being merged to both develop and master branches of the respective repos: