-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[공통] release -> main #346
[공통] release -> main #346
Conversation
[FE] 비회원 로그인 및 디자인 수정
[FE] Dev fe -> release
like문 대신 전문검색 사용
500 -> 250 ms 성능개선
[BE] feat#331 부하테스트 위한 커스텀 메트릭 측정 기능 구현
[BE] dev-be -> release
[BE] feat#333 updatePos socket batch 처리
Dev be to release
[BE] feat#329 퀴즈검색 성능개선
- 기존의 국민연금 폰트는 서브셋이여서 보이지 않는 글자가 있었음(눜, 뷁)
[BE] feat#333 배치기능 모듈화
[FE] updatePosition 및 chatMessage 이벤트 배치 적용 및 디자인 변경
Dev be to release
[FE] Dev fe -> release
[BE] fix: position 키 변경일 때만 배치처리
[BE] Dev be -> release
[BE] feat: DEAD 상태 메시지 배치 처리 추가
[BE] dev-be -> release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 26 out of 41 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- BE/package-lock.json: Language not supported
- BE/package.json: Language not supported
- BE/src/game/interceptor/gameActivity.interceptor.ts: Evaluated as low risk
- BE/src/app.module.ts: Evaluated as low risk
- BE/src/common/constants/batch-time.ts: Evaluated as low risk
- BE/src/common/interceptor/SocketEventLoggerInterceptor.ts: Evaluated as low risk
- BE/src/game/game.gateway.ts: Evaluated as low risk
- BE/src/game/game.module.ts: Evaluated as low risk
- BE/src/metric/metric.service.ts: Evaluated as low risk
- BE/src/game/redis/subscribers/player.subscriber.ts: Evaluated as low risk
- BE/src/quiz-set/entities/quiz-choice.entity.ts: Evaluated as low risk
- BE/src/InitDB/QUIZ_SET_TEST_DATA.ts: Evaluated as low risk
- BE/src/game/service/game.service.ts: Evaluated as low risk
- BE/src/main.ts: Evaluated as low risk
- BE/src/game/service/game.chat.service.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)
BE/src/game/service/batch.processor.ts:90
- Consider removing the nested try-catch block for better readability. The error handling can be simplified.
private async processBatch(): Promise<void> {
BE/src/game/service/batch.processor.ts:56
- [nitpick] Consider defining batchProcessHandlers as a method instead of an object within the class for better readability.
private batchProcessHandlers: Record<BatchProcessorType, (gameId: string, batch: any[]) => Promise<void>> = {
constructor(private metricService: MetricService) {} | ||
|
||
@Post('start') | ||
async startMetric() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method does not handle exceptions that might be thrown by the MetricService methods. Add a try-catch block to handle potential errors.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
} | ||
|
||
@Post('stop') | ||
async stopMetric() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method does not handle exceptions that might be thrown by the MetricService methods. Add a try-catch block to handle potential errors.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
ex) [BE] feat#156 자동배포 구현
(확인 후 지워주세요)
➕ 이슈 번호
🔎 작업 내용
🖼 참고 이미지
🎯 리뷰 요구사항 (선택)
✅ Check List