Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] feat: DEAD 상태 메시지 배치 처리 추가 #343

Merged
merged 6 commits into from
Jan 2, 2025

Conversation

songbuild00
Copy link
Collaborator

🔎 작업 내용

  • DEAD 상태 메시지 배치 처리 추가
  • BatchProcessorType 추가

✅ Check List

  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

@Copilot Copilot bot review requested due to automatic review settings December 27, 2024 01:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

BE/src/game/service/BatchProcessor.ts:13

  • The new behavior introduced by 'BatchProcessorType.ONLY_DEAD' should be covered by tests to ensure it works as expected.
export enum BatchProcessorType { 'DEFAULT', 'ONLY_DEAD' }

BE/src/game/service/BatchProcessor.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@DongHoonYu96 DongHoonYu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ijun17 ijun17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@NewCodes7 NewCodes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쓰다보니 길어졌네요 ㅎㅎ.. 배치처리는 문서에도 담겨야 할 코드라 신경 좀 써봤어요!

BE/src/game/service/game.chat.service.ts Outdated Show resolved Hide resolved
BE/src/game/service/game.chat.service.ts Outdated Show resolved Hide resolved
BE/src/game/service/BatchProcessor.ts Outdated Show resolved Hide resolved
BE/src/game/redis/subscribers/player.subscriber.ts Outdated Show resolved Hide resolved
BE/src/game/redis/subscribers/player.subscriber.ts Outdated Show resolved Hide resolved
BE/src/game/service/BatchProcessor.ts Outdated Show resolved Hide resolved
BE/src/game/service/game.chat.service.ts Outdated Show resolved Hide resolved
@NewCodes7 NewCodes7 requested a review from Copilot January 1, 2025 10:47

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • BE/src/game/service/BatchProcessor.ts: Evaluated as low risk
@songbuild00 songbuild00 merged commit 932a8ab into boostcampwm-2024:dev-be Jan 2, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants