-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] feat: DEAD 상태 메시지 배치 처리 추가 #343
[BE] feat: DEAD 상태 메시지 배치 처리 추가 #343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
BE/src/game/service/BatchProcessor.ts:13
- The new behavior introduced by 'BatchProcessorType.ONLY_DEAD' should be covered by tests to ensure it works as expected.
export enum BatchProcessorType { 'DEFAULT', 'ONLY_DEAD' }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
쓰다보니 길어졌네요 ㅎㅎ.. 배치처리는 문서에도 담겨야 할 코드라 신경 좀 써봤어요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- BE/src/game/service/BatchProcessor.ts: Evaluated as low risk
🔎 작업 내용
✅ Check List