Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] updatePosition 및 chatMessage 이벤트 배치 적용 및 디자인 변경 #337

Merged
merged 10 commits into from
Dec 25, 2024

Conversation

ijun17
Copy link
Collaborator

@ijun17 ijun17 commented Dec 23, 2024

🔎 작업 내용

  • updatePosition 및 chatMessage 이벤트 소켓 배치 적용
  • 하위 호환성을 위해 배치로 보내지 않아도 돌아가게 했습니다
  • 일부 디자인 변경
    • 정답 모달에서 정답 여부만 보여줌
    • 선택지가 길어질 때 박스를 넘어가지 않도록 수정
    • 퀴즈 프리뷰 줄바꿈 3까지 가능 그 뒤에는 ...으로 표시
    • 채팅 "~환영합니다" 변경
    • 폰트 변경(일부 글자가 보이지 않는 이슈로)

🖼 참고 이미지


🎯 리뷰 요구사항 (선택)

배치에 관련된 변경사항은 아래 두 파일만 보시면 됩니다.


✅ Check List

  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

@ijun17 ijun17 changed the title [FE] updatePosition 및 chatMessage 이벤트 소켓 배치 적용 [FE] updatePosition 및 chatMessage 이벤트 배치 적용 및 디자인 변경 Dec 23, 2024
@ijun17 ijun17 self-assigned this Dec 24, 2024
@DongHoonYu96 DongHoonYu96 requested a review from Copilot December 25, 2024 04:13

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (7)
  • FE/package-lock.json: Language not supported
  • FE/package.json: Language not supported
  • FE/src/index.css: Language not supported
  • FE/src/api/socket/socketEventTypes.ts: Evaluated as low risk
  • FE/src/components/QuizPreview.tsx: Evaluated as low risk
  • FE/src/features/game/components/AnswerModal.tsx: Evaluated as low risk
  • FE/src/features/game/components/Chat.tsx: Evaluated as low risk
Copy link
Collaborator

@DongHoonYu96 DongHoonYu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijun17 ijun17 merged commit 3e40808 into boostcampwm-2024:dev-fe Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants