-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] updatePosition 및 chatMessage 이벤트 배치 적용 및 디자인 변경 #337
Merged
ijun17
merged 10 commits into
boostcampwm-2024:dev-fe
from
ijun17:feature-fe-batch-socket
Dec 25, 2024
Merged
[FE] updatePosition 및 chatMessage 이벤트 배치 적용 및 디자인 변경 #337
ijun17
merged 10 commits into
boostcampwm-2024:dev-fe
from
ijun17:feature-fe-batch-socket
Dec 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 기존의 국민연금 폰트는 서브셋이여서 보이지 않는 글자가 있었음(눜, 뷁)
ijun17
changed the title
[FE] updatePosition 및 chatMessage 이벤트 소켓 배치 적용
[FE] updatePosition 및 chatMessage 이벤트 배치 적용 및 디자인 변경
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (7)
- FE/package-lock.json: Language not supported
- FE/package.json: Language not supported
- FE/src/index.css: Language not supported
- FE/src/api/socket/socketEventTypes.ts: Evaluated as low risk
- FE/src/components/QuizPreview.tsx: Evaluated as low risk
- FE/src/features/game/components/AnswerModal.tsx: Evaluated as low risk
- FE/src/features/game/components/Chat.tsx: Evaluated as low risk
songbuild00
approved these changes
Dec 25, 2024
DongHoonYu96
approved these changes
Dec 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NewCodes7
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔎 작업 내용
🖼 참고 이미지
🎯 리뷰 요구사항 (선택)
배치에 관련된 변경사항은 아래 두 파일만 보시면 됩니다.
✅ Check List