-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] feat#331 부하테스트 위한 커스텀 메트릭 측정 기능 구현 #332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (10)
- BE/package-lock.json: Language not supported
- BE/package.json: Language not supported
- BE/src/game/service/game.chat.service.ts: Evaluated as low risk
- BE/src/common/interceptor/SocketEventLoggerInterceptor.ts: Evaluated as low risk
- BE/src/game/game.gateway.ts: Evaluated as low risk
- BE/src/game/game.module.ts: Evaluated as low risk
- BE/src/game/interceptor/gameActivity.interceptor.ts: Evaluated as low risk
- BE/src/game/redis/subscribers/player.subscriber.ts: Evaluated as low risk
- BE/src/app.module.ts: Evaluated as low risk
- BE/src/game/service/game.service.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)
BE/src/metric/metric.service.ts:215
- The calculateSystemStats method has commented-out code that should either be removed or uncommented if it's necessary.
private calculateSystemStats(startSystemMetrics: SystemMetricSnapshot, systemSnapshots: SystemMetricSnapshot[]) {
BE/src/metric/metric.service.ts:282
- The calculatePercentile method returns 0 if the sortedValues array is empty. This might be intended, but we should confirm.
if (sortedValues.length === 0) return 0;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (10)
- BE/package-lock.json: Language not supported
- BE/package.json: Language not supported
- BE/src/metric/metric.controller.ts: Evaluated as low risk
- BE/src/game/interceptor/gameActivity.interceptor.ts: Evaluated as low risk
- BE/src/game/redis/subscribers/player.subscriber.ts: Evaluated as low risk
- BE/src/game/service/game.chat.service.ts: Evaluated as low risk
- BE/src/game/service/game.service.ts: Evaluated as low risk
- BE/src/metric/interfaces/metric.interface.ts: Evaluated as low risk
- BE/src/metric/metric.interceptor.ts: Evaluated as low risk
- BE/src/metric/metric.module.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
BE/src/game/game.gateway.ts:30
- The new MetricInterceptor functionality is not covered by tests. Ensure that the metrics collection is properly tested.
@UseInterceptors(MetricInterceptor)
➕ 이슈 번호
🔎 작업 내용
/api/metric/start로 post 요청 보내면 메트릭 측정 시작
/api/metric/stop으로 post 요청 보내면 메트릭 측정 멈추고, 결과 반환
메트릭 측정하고자 하는 지표 (아래 테스트한 예시)
🎯 리뷰 요구사항 (선택)
✅ Check List