updated for Blender 2.8 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doakey3
commented
Dec 9, 2018
doakey3
commented
- Minor changes made to the code to bring it up to Blender version 2.8
- I put the code into a init.py file so users will install the add-on using the downloaded .zip which is more consistent with other newer add-ons
- I updated the README to describe installation and usage
boombatower
reviewed
Dec 12, 2018
__init__.py
Outdated
|
|
||
| # add the frame change handler | ||
| bpy.app.handlers.scene_update_pre.append(typewriter_text_update_frame) | ||
| bpy.app.handlers.frame_change_pre.append(typewriter_text_update_frame) |
Owner
There was a problem hiding this comment.
Is the change from scene_update_pre to frame_change_pre and the change from register_module to register_class the only actual functional changes? It seems like virtually everything is style changes and README changes.
We need to explicitly evaluate the object as described here: https://wiki.blender.org/wiki/Reference/Release_Notes/2.81/Python_API#Handlers in order to get all current value of any fcurve-animated properties.
Fix animation render with keyframed typewriter properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.