Repository navigation
Enforce lock-file integrity when downloading RPM blobs. - #7
Merged
Merged
Conversation
The config/lock-file code path (bazeldnf.config -> _handle_lock_file -> _add_blob_rpm_repository) creates the repository that actually downloads each RPM, but never forwards the lock file's integrity/sha256 to the underlying rpm_repository rule. As a result ctx.download runs without a checksum, so a stale or mismatched hash in the lock file is never caught by any fetch or build (only the manual bazeldnf.rpm(...) tag path forwarded these fields). Thread the lock entry's hash through so ctx.download verifies it. Entries that carry neither field remain unverified, exactly as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config/lock-file code path (bazeldnf.config -> _handle_lock_file -> _add_blob_rpm_repository) creates the repository that actually downloads each RPM, but never forwards the lock file's integrity/sha256 to the underlying rpm_repository rule. As a result ctx.download runs without a checksum, so a stale or mismatched hash in the lock file is never caught by any fetch or build (only the manual bazeldnf.rpm(...) tag path forwarded these fields).
Thread the lock entry's hash through so ctx.download verifies it. Entries that carry neither field remain unverified, exactly as before.